instance_id stringlengths 17 41 | org stringclasses 19
values | repo stringclasses 19
values | number int64 29 21.7k | state stringclasses 1
value | title stringlengths 9 118 | body stringlengths 10 5.5k | base unknown | resolved_issues unknown | lang stringclasses 4
values | problem_statement stringlengths 51 34.5k | hints stringlengths 1 65.8k ⌀ | pull_url stringlengths 40 64 | issue_urls unknown | test_command stringlengths 66 10.4k ⌀ | fix_patch stringlengths 365 784k | test_patch stringlengths 382 698k | n2p_tests unknown | f2p_tests unknown | p2p_tests unknown | s2p_tests unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
thunderbird__thunderbird-android-6190 | thunderbird | thunderbird-android | 6,190 | closed | Fix removing multiple notifications at once | Fixes #6077 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b1083bef93471dff0448690140290a450d83c295"
} | [
{
"number": 6077,
"title": "Duplicate notifications for new messages",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.000\n\n### ... | kotlin | Duplicate notifications for new messages
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.000
### Where did you get the app from?
Google Play
### Android versio... | 
I actually got 8 mails, bit only one was about wxMaxima
This also happens to me sometimes, a bunch of duplicate notifications for the same email. I am using K-9 Mail 6.0 on GrapheneOS ... | https://github.com/thunderbird/thunderbird-android/pull/6190 | [
"https://github.com/thunderbird/thunderbird-android/issues/6077"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.notification.NotificationDataStoreTest" | diff --git a/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt b/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt
index db99f40340e..de9f8c94bea 100644
--- a/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt
+++ b/app/core/src/main/java/com/fsck/k9/n... | diff --git a/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt b/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt
index 57ffc8aba4f..c3000f77111 100644
--- a/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt
+++ b/app/core/src/test/java/c... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testNewMessagesCount": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.remove all notifications": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.Noti... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testGetHolderForLatestNotification": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.testAddNotificationContentWithReplacingNotification": {
"run": "PASS",
"test": "FAIL",
"fix": "PA... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testRemoveDoesNotLeakNotificationIds": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.adding notification for message with active notification should update notification": {
"run": "PASS",
... | {} |
thunderbird__thunderbird-android-6172 | thunderbird | thunderbird-android | 6,172 | closed | Allow all URI schemes in links | Fixes #6103 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "2ac66fe9ce6a875c189632830c761e62dbb7dbf9"
} | [
{
"number": 6103,
"title": "sms: link not working",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.000\n\n### Where did you get t... | kotlin | sms: link not working
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.000
### Where did you get the app from?
Google Play
### Android version
7.1.1
### Devic... | I confirm.
It seams to be a "parsing issue", links built with a sms: URI are not recognized "as links" so they are not clickable.
Tested forms :
<a href="sms:+0102030405&body=Hello" ...
<a href="sms:?body=Hello" ...
<a href="sms:&body=Hello" ...
<a href="sms:?&body=Hello" ...
<a href="sms:/?&body=Hello" ... | https://github.com/thunderbird/thunderbird-android/pull/6172 | [
"https://github.com/thunderbird/thunderbird-android/issues/6103"
] | ./gradlew :app:html-cleaner:test --tests "app.k9mail.html.cleaner.HtmlSanitizerTest" | diff --git a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt b/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
index 327d7f80613..80fa043e840 100644
--- a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
+++ b/app/html-cleaner/src/main/java/app/k9mail/htm... | diff --git a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt b/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
index 9ebc3857b5e..12ea9e797b9 100644
--- a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
+++ b/app/html-cleaner/src/test/j... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInHead": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepUris": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.should... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepAllowedElementsInHeadAndSkipTheRest": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshWithUpperCaseAttributeValue": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldNormalizeTables": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.clea... | {} |
thunderbird__thunderbird-android-6082 | thunderbird | thunderbird-android | 6,082 | closed | Add support for OAuth 2.0 (Gmail) | The implementation cuts a few corners. The plan is to clean this up when we rework the account setup code to support Thunderbird's Autoconfiguration (#865).
Fixes #655 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "e1ff582cac7191254dc00d61ebfcab63bfce8011"
} | [
{
"number": 655,
"title": "Add support for Gmail's XOAUTH2",
"body": "I really do not want to allow \"less secure apps\" in my gmail account.\nWould K9Mail be compatible with this gmail security some time in a future?\n"
}
] | kotlin | Add support for Gmail's XOAUTH2
I really do not want to allow "less secure apps" in my gmail account.
Would K9Mail be compatible with this gmail security some time in a future?
| "Less secure apps", as far as I'm aware, really just means apps that don't use Google's proprietary APIs, rather than using standards like K-9 does.
You can also use an "app-specific password" created from your Google account, which is a part of their two-factor authentication system, which you should be using anyways... | https://github.com/thunderbird/thunderbird-android/pull/6082 | [
"https://github.com/thunderbird/thunderbird-android/issues/655"
] | ./gradlew :mail:protocols:smtp:test --tests "com.fsck.k9.mail.transport.smtp.SmtpTransportTest" :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapConnectionTest" | diff --git a/app/autodiscovery/providersxml/src/main/java/com/fsck/k9/autodiscovery/providersxml/ProvidersXmlDiscovery.kt b/app/autodiscovery/providersxml/src/main/java/com/fsck/k9/autodiscovery/providersxml/ProvidersXmlDiscovery.kt
index ef7651fe10b..0992656beb4 100644
--- a/app/autodiscovery/providersxml/src/main/jav... | diff --git a/app/autodiscovery/providersxml/src/test/java/com/fsck/k9/autodiscovery/providersxml/ProvidersXmlDiscoveryTest.kt b/app/autodiscovery/providersxml/src/test/java/com/fsck/k9/autodiscovery/providersxml/ProvidersXmlDiscoveryTest.kt
index b1bf51c5019..5f36f322391 100644
--- a/app/autodiscovery/providersxml/src/... | {
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() with NAMESPACE capability should issue NAMESPACE command": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.sendContinuation() should send line without tag": {
"run": "PASS",
"test... | {} | {} | {} |
thunderbird__thunderbird-android-6080 | thunderbird | thunderbird-android | 6,080 | closed | Ignore invalid SMTP EHLO response lines | Fixes #6062 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "c78d70719b500ac2798ec9b1a44dd2ed77d366b4"
} | [
{
"number": 6062,
"title": "EHLO keyword contains invalid character",
"body": "### Checklist\r\n\r\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\r\n- [X] I will describe the problem with as much detail as possible.\r\n\r\n### App version\r\n\r\n... | kotlin | EHLO keyword contains invalid character
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
d13352a4cd7f5ea540eba738155ff377ee48da62 - 2205202769770bc37feb98414b... | The server's response to the `EHLO` command starts with:
```text
250-mail.example.com Hello <REDACTED> [<REDACTED>]
250-SIZE 52428800
250-8BITMIME
250-PIPELINING
250-PIPE_CONNECT
```
`PIPE_CONNECT` contains an underscore, which is not allowed. See https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.... | https://github.com/thunderbird/thunderbird-android/pull/6080 | [
"https://github.com/thunderbird/thunderbird-android/issues/6062"
] | ./gradlew :mail:protocols:smtp:test --tests "com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest" | diff --git a/mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt b/mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt
index e67febebd16..a7ceefaa101 100644
--- a/mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.... | diff --git a/mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParserTest.kt b/mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParserTest.kt
index e3f349201c6..9b813c0ae5c 100644
--- a/mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpRespons... | {
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.read EHLO response with invalid parameter": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.read EHLO response with invalid keywords": {
"run": "NONE",
"test": "NONE",
"fix":... | {
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.read EHLO response with empty parameter": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.multi-line response with text": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
... | {
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.multi-line response without text on last line": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.response with invalid enhanced status code subject": {
"run": "PASS",
"test": "PAS... | {} |
thunderbird__thunderbird-android-6043 | thunderbird | thunderbird-android | 6,043 | closed | Move `DefaultTrustedSocketFactory` | Closes #6012 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "e4b82ad37bf934d0fa1dec1439f6fed2e767460b"
} | [
{
"number": 6012,
"title": "Move `DefaultTrustedSocketFactory`",
"body": "`DefaultTrustedSocketFactory` depends on the Android SDK and therefore should not live inside the `:mail:common` Gradle project.\r\n\r\nRelated class: `KeyChainKeyManager`"
}
] | kotlin | Move `DefaultTrustedSocketFactory`
`DefaultTrustedSocketFactory` depends on the Android SDK and therefore should not live inside the `:mail:common` Gradle project.
Related class: `KeyChainKeyManager`
| null | https://github.com/thunderbird/thunderbird-android/pull/6043 | [
"https://github.com/thunderbird/thunderbird-android/issues/6012"
] | ./gradlew :mail:protocols:webdav:testDebugUnitTest --tests "com.fsck.k9.mail.store.webdav.WebDavStoreTest" | diff --git a/app/core/src/main/java/com/fsck/k9/KoinModule.kt b/app/core/src/main/java/com/fsck/k9/KoinModule.kt
index 05c30287cc1..85cacac5b97 100644
--- a/app/core/src/main/java/com/fsck/k9/KoinModule.kt
+++ b/app/core/src/main/java/com/fsck/k9/KoinModule.kt
@@ -2,7 +2,7 @@ package com.fsck.k9
import android.conte... | diff --git a/mail/protocols/webdav/src/test/java/com/fsck/k9/mail/store/webdav/WebDavStoreTest.java b/mail/protocols/webdav/src/test/java/com/fsck/k9/mail/store/webdav/WebDavStoreTest.java
index 958ee1f1599..8cb66466e2e 100644
--- a/mail/protocols/webdav/src/test/java/com/fsck/k9/mail/store/webdav/WebDavStoreTest.java
... | {
"com.fsck.k9.mail.store.webdav.WebDavStoreTest.checkSettings_withErrorResponse_shouldThrow": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.webdav.WebDavStoreTest.checkSettings_withInitialUnauthorizedResponse_shouldPerformBasicAuthentication": {
"run": "PASS",
"tes... | {} | {} | {} |
thunderbird__thunderbird-android-6041 | thunderbird | thunderbird-android | 6,041 | closed | Move `MailTo` and `ListHeaders` classes | Closes #6014 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "4a9a7baf79705601d1fcf83c665080ba1d543266"
} | [
{
"number": 6014,
"title": "Move `MailTo` and `ListHeaders`",
"body": "These classes depend on the Android SDK and therefore should not live inside the `:mail:common` Gradle project.\r\n\r\nAlternatively, we could change the implementation to not use Android's `Uri` class."
}
] | kotlin | Move `MailTo` and `ListHeaders`
These classes depend on the Android SDK and therefore should not live inside the `:mail:common` Gradle project.
Alternatively, we could change the implementation to not use Android's `Uri` class.
| null | https://github.com/thunderbird/thunderbird-android/pull/6041 | [
"https://github.com/thunderbird/thunderbird-android/issues/6014"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.helper.MailToTest" --tests "com.fsck.k9.helper.ListHeadersTest" --tests "com.fsck.k9.helper.ReplyToParserTest" | diff --git a/mail/common/src/main/java/com/fsck/k9/mail/internet/ListHeaders.java b/app/core/src/main/java/com/fsck/k9/helper/ListHeaders.java
similarity index 96%
rename from mail/common/src/main/java/com/fsck/k9/mail/internet/ListHeaders.java
rename to app/core/src/main/java/com/fsck/k9/helper/ListHeaders.java
index ... | diff --git a/mail/common/src/test/java/com/fsck/k9/mail/internet/ListHeadersTest.java b/app/core/src/test/java/com/fsck/k9/helper/ListHeadersTest.java
similarity index 98%
rename from mail/common/src/test/java/com/fsck/k9/mail/internet/ListHeadersTest.java
rename to app/core/src/test/java/com/fsck/k9/helper/ListHeaders... | {
"com.fsck.k9.helper.ListHeadersTest.getListPostAddresses_withMailtoWithNote_shouldReturnCorrectAddress": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.helper.MailToTest.testGetCc_singleEmailAddress": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.help... | {} | {} | {} |
thunderbird__thunderbird-android-6030 | thunderbird | thunderbird-android | 6,030 | closed | Fix bug in `FlowedMessageUtils.deflow()` | Fixes #6029 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "a5b58dc6fed5a626e45720f3ce327f887a68d58c"
} | [
{
"number": 6029,
"title": "Broken quoting of plain text mail",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.000\n\n### Where d... | kotlin | Broken quoting of plain text mail
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.000
### Where did you get the app from?
Google Play
### Android version
Andr... | I can't reproduce the issue with the text snippet you've provided. Can you attach the (redacted) message source (including headers)?
Here's the (redacted) EML file
[k9.zip](https://github.com/k9mail/k-9/files/8523702/k9.zip)
| https://github.com/thunderbird/thunderbird-android/pull/6030 | [
"https://github.com/thunderbird/thunderbird-android/issues/6029"
] | ./gradlew :mail:common:testDebugUnitTest --tests "com.fsck.k9.mail.internet.FlowedMessageUtilsTest" | diff --git a/mail/common/src/main/java/com/fsck/k9/mail/internet/FlowedMessageUtils.java b/mail/common/src/main/java/com/fsck/k9/mail/internet/FlowedMessageUtils.java
index 25a10847b4d..580a5acaa2e 100644
--- a/mail/common/src/main/java/com/fsck/k9/mail/internet/FlowedMessageUtils.java
+++ b/mail/common/src/main/java/c... | diff --git a/mail/common/src/test/java/com/fsck/k9/mail/internet/FlowedMessageUtilsTest.kt b/mail/common/src/test/java/com/fsck/k9/mail/internet/FlowedMessageUtilsTest.kt
new file mode 100644
index 00000000000..cf70f7145a4
--- /dev/null
+++ b/mail/common/src/test/java/com/fsck/k9/mail/internet/FlowedMessageUtilsTest.kt... | {
"com.fsck.k9.mail.internet.FlowedMessageUtilsTest.deflow() with quoted text ending in space followed by empty line": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.internet.FlowedMessageUtilsTest.deflow() with simple text": {
"run": "NONE",
"test": "NONE",
"fix": "PA... | {
"com.fsck.k9.mail.internet.FlowedMessageUtilsTest.deflow() with space-stuffed second line": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.internet.FlowedMessageUtilsTest.deflow() with only space-stuffing": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.internet.FlowedMessageUtilsTest.deflow() with text containing signature": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"com.f... | {} |
thunderbird__thunderbird-android-5989 | thunderbird | thunderbird-android | 5,989 | closed | Truncate file when overwriting existing settings file | Fixes #5988 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b5f6e00dab70c0dcfe414a72ef9d591d41ebcc64"
} | [
{
"number": 5988,
"title": "Impossible to import settings",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n5.913\n\n### Where did y... | kotlin | Impossible to import settings
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.913
### Where did you get the app from?
F-Droid
### Android version
11
### Devi... | I add here the part of my file concerned by the error (@727:45 )
I insist on the fact that I did not edit this file and that it is the result of the action "Export parameters"
```
726 </accounts>
727</k9settings>lue key="pushMode">SECOND_CLASS</value>
728 </folder>
```
Since a new reinstallation, the ... | https://github.com/thunderbird/thunderbird-android/pull/5989 | [
"https://github.com/thunderbird/thunderbird-android/issues/5988"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.logging.LogcatLogFileWriterTest" | diff --git a/app/core/src/main/java/com/fsck/k9/logging/LogFileWriter.kt b/app/core/src/main/java/com/fsck/k9/logging/LogFileWriter.kt
index d81c9e16611..831637708c6 100644
--- a/app/core/src/main/java/com/fsck/k9/logging/LogFileWriter.kt
+++ b/app/core/src/main/java/com/fsck/k9/logging/LogFileWriter.kt
@@ -26,7 +26,7 ... | diff --git a/app/core/src/test/java/com/fsck/k9/logging/LogcatLogFileWriterTest.kt b/app/core/src/test/java/com/fsck/k9/logging/LogcatLogFileWriterTest.kt
index 2fcc6e93ff9..a4229bbb0d8 100644
--- a/app/core/src/test/java/com/fsck/k9/logging/LogcatLogFileWriterTest.kt
+++ b/app/core/src/test/java/com/fsck/k9/logging/Lo... | {} | {
"com.fsck.k9.logging.LogcatLogFileWriterTest.write log to contentUri": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.logging.LogcatLogFileWriterTest.processExecutor throws": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.logging.LogcatLogFileWriterTes... | {} | {} |
thunderbird__thunderbird-android-5958 | thunderbird | thunderbird-android | 5,958 | closed | Add support for duplicate "charset" parameters with matching values | - For extracting the `charset` parameter value, we only need basic (RFC 2045) parameter decoding.
- We typically ignore duplicate parameters (parameter name used more than once) because it's not specified which one to pick. We relax this rule to support the case where all `charset` values are equivalent, e.g. `Conten... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b9efb70d0ef5f9f0e15944a43dbe956f8e76c5c9"
} | [
{
"number": 5951,
"title": "Incorrect encoding of the email text / Torrent tracker SoftPilot.win",
"body": "### Checklist\r\n\r\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\r\n- [X] I will describe the problem with as much detail as possible.\r... | kotlin | Incorrect encoding of the email text / Torrent tracker SoftPilot.win
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.912
### Where did you get the app f... | Can you attach the message source?
Chances are the email is not properly declaring the character set that is used. That would be a bug in the software creating the message, not one in K-9 Mail.
Many email apps attempt to guess the character set in order to display the message as intended. K-9 Mail doesn't do that.... | https://github.com/thunderbird/thunderbird-android/pull/5958 | [
"https://github.com/thunderbird/thunderbird-android/issues/5951"
] | ./gradlew :mail:common:testDebugUnitTest --tests "com.fsck.k9.mail.internet.PartExtensionsTest" | diff --git a/mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java b/mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java
index e45aa18e34a..c54f469be8a 100644
--- a/mail/common/src/main/java/com/fsck/k9/mail/internet/MessageExtractor.java
+++ b/mail/common/src/main/java/com/fsc... | diff --git a/mail/common/src/test/java/com/fsck/k9/mail/internet/PartExtensionsTest.kt b/mail/common/src/test/java/com/fsck/k9/mail/internet/PartExtensionsTest.kt
new file mode 100644
index 00000000000..f5afbdec568
--- /dev/null
+++ b/mail/common/src/test/java/com/fsck/k9/mail/internet/PartExtensionsTest.kt
@@ -0,0 +1,... | {
"com.fsck.k9.mail.internet.PartExtensionsTest.get charset with two charset parameters where values differ in quoting": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.internet.PartExtensionsTest.get charset with two charset parameters where values differ in case": {
"run": "N... | {} | {} | {} |
thunderbird__thunderbird-android-5946 | thunderbird | thunderbird-android | 5,946 | closed | Add support for updating existing notifications | Fixes #5892 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b5d1ac7bdce7f1941fef5d9ff2f6d661657f4ae0"
} | [
{
"number": 5892,
"title": "Two notifications for the same message",
"body": "### Checklist\r\n\r\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\r\n- [X] I will describe the problem with as much detail as possible.\r\n\r\n### App version\r\n\r\n5... | kotlin | Two notifications for the same message
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.910
### Where did you get the app from?
Other
### Android v... | I think I have the same issue using a POP3 server. If I swipe out the notification of a new message in the notification center, the same entry will show again some seconds later. After swiping out a second time, the notification disappears as expected.
Version: 5.910 from f-droid
Android: 8.1
@Showmaster3000: That'... | https://github.com/thunderbird/thunderbird-android/pull/5946 | [
"https://github.com/thunderbird/thunderbird-android/issues/5892"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.notification.NotificationDataStoreTest" --tests "com.fsck.k9.notification.NewMailNotificationManagerTest" | diff --git a/app/core/src/main/java/com/fsck/k9/notification/NewMailNotificationController.kt b/app/core/src/main/java/com/fsck/k9/notification/NewMailNotificationController.kt
index 19014486211..c29c7791f53 100644
--- a/app/core/src/main/java/com/fsck/k9/notification/NewMailNotificationController.kt
+++ b/app/core/src... | diff --git a/app/core/src/test/java/com/fsck/k9/notification/NewMailNotificationManagerTest.kt b/app/core/src/test/java/com/fsck/k9/notification/NewMailNotificationManagerTest.kt
index 72e8a193d58..105f49649b5 100644
--- a/app/core/src/test/java/com/fsck/k9/notification/NewMailNotificationManagerTest.kt
+++ b/app/core/... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testNewMessagesCount": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.testAddNotificationContent": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.No... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testGetHolderForLatestNotification": {
"run": "SKIP",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.testAddNotificationContentWithReplacingNotification": {
"run": "PASS",
"test": "FAIL",
"fix": "PA... | {
"com.fsck.k9.notification.NewMailNotificationManagerTest.remove notification when additional notifications are available": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.notification.NewMailNotificationManagerTest.restore notifications with one inactive persisted notification": {
... | {} |
thunderbird__thunderbird-android-5896 | thunderbird | thunderbird-android | 5,896 | closed | Retain doctype when sanitizing HTML | Fixes #5882 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "5c0b99fbdcf436bbc522b2eca9caeee7e2e75cb9"
} | [
{
"number": 5882,
"title": "broken display of",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n5.9.10\n\n### Where did you get the ... | kotlin | broken display of
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.9.10
### Where did you get the app from?
Other
### Android version
Android 11, Havoc OS (cus... | I created a command line application that modifies HTML the same way that K-9 Mail does. See #5885
Could you use this to debug the issue yourself?
yes,
I finally had the time to look at this.
I tested this in Firefox and used the inspection tools in order to switch to a mobile layout (smartphone icon on the righ... | https://github.com/thunderbird/thunderbird-android/pull/5896 | [
"https://github.com/thunderbird/thunderbird-android/issues/5882"
] | ./gradlew :app:html-cleaner:test --tests "app.k9mail.html.cleaner.HtmlSanitizerTest" | diff --git a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt b/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
index 70045fe60bf..0720118d385 100644
--- a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
+++ b/app/html-cleaner/src/main/java/app/k9mail/htm... | diff --git a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt b/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
index 7630fd56271..9ebc3857b5e 100644
--- a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
+++ b/app/html-cleaner/src/test/j... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInHead": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshButKeepOtherMetaTags": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cle... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepAllowedElementsInHeadAndSkipTheRest": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInBody": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshWithUpperCaseAttributeValue": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepUris": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.Htm... | {} |
thunderbird__thunderbird-android-5881 | thunderbird | thunderbird-android | 5,881 | closed | Stop using AUTH without arguments (POP3) | At least one server software closes the connection right away after receiving the AUTH command without arguments. Since using the AUTH command without arguments never made it into a standard, I decided to completely remove this functionality.
Fixes #5879 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "de15580e400b8101a10d824fbc6e8a111373880d"
} | [
{
"number": 5879,
"title": "Can't connect to POP3 server (IONOS, GMX, maybe others)",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n... | kotlin | Can't connect to POP3 server (IONOS, GMX, maybe others)
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
5.806
### Where did you get the app from?
Google Play
###... | Related:
- https://forum.k9mail.app/t/no-pop3-email-from-ionos-unable-to-execute-pop3-command/4017
- https://forum.k9mail.app/t/fetching-mails-from-gmx-stopped-working-certificate-error-configuration-fails-starttls-not-available/4021
When establishing a connection K-9 Mail sends an `AUTH` command without arguments... | https://github.com/thunderbird/thunderbird-android/pull/5881 | [
"https://github.com/thunderbird/thunderbird-android/issues/5879"
] | ./gradlew :mail:protocols:pop3:testDebugUnitTest --tests "com.fsck.k9.mail.store.pop3.Pop3StoreTest" --tests "com.fsck.k9.mail.store.pop3.Pop3ConnectionTest" | diff --git a/mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java b/mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java
index 666d4006533..2a0d004e263 100644
--- a/mail/protocols/pop3/src/main/java/com/fsck/k9/mail/store/pop3/Pop3Connection.java
+++ b/mail/prot... | diff --git a/mail/protocols/pop3/src/test/java/com/fsck/k9/mail/store/pop3/Pop3ConnectionTest.java b/mail/protocols/pop3/src/test/java/com/fsck/k9/mail/store/pop3/Pop3ConnectionTest.java
index 5bcab0b0256..9f8d0b6e18d 100644
--- a/mail/protocols/pop3/src/test/java/com/fsck/k9/mail/store/pop3/Pop3ConnectionTest.java
+++... | {
"com.fsck.k9.mail.store.pop3.Pop3ConnectionTest.open_whenTrustedSocketFactoryThrowsGeneralSecurityException_throwMessagingException": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.pop3.Pop3ConnectionTest.open_whenTrustedSocketFactoryThrowsSSLCertificateException_throwCert... | {
"com.fsck.k9.mail.store.pop3.Pop3StoreTest.open_withAuthResponseUsingAuthPlain_shouldRetrieveMessageCountOnAuthenticatedSocket": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.mail.store.pop3.Pop3ConnectionTest.open_withStartTLS_withSTLSerr_doesntCreateSocket": {
"run": "PASS",
... | {
"com.fsck.k9.mail.store.pop3.Pop3StoreTest.getFolder_shouldReturnFolderWithCorrectName": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.store.pop3.Pop3ConnectionTest.open_withSTLSunavailable_doesntCreateSocket": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"... | {} |
thunderbird__thunderbird-android-5812 | thunderbird | thunderbird-android | 5,812 | closed | Only set vibration pattern if vibration is enabled | Fixes #5811 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b671c7dbe42361a5666f8da48456fb0eed66204c"
} | [
{
"number": 5811,
"title": "Notification causes vibration for account despite disabled vibration",
"body": "**Describe the bug**\r\nSince version 5.905, the settings of disabled vibrations for a single account doesn't have a effect. The notification still causes a vibration.\r\n\r\n**To Reproduce**\r\nS... | kotlin | Notification causes vibration for account despite disabled vibration
**Describe the bug**
Since version 5.905, the settings of disabled vibrations for a single account doesn't have a effect. The notification still causes a vibration.
**To Reproduce**
Steps to reproduce the behavior:
1. Add a account and set the n... | null | https://github.com/thunderbird/thunderbird-android/pull/5812 | [
"https://github.com/thunderbird/thunderbird-android/issues/5811"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.notification.NewMailNotificationManagerTest" | diff --git a/app/core/src/main/java/com/fsck/k9/notification/BaseNotificationDataCreator.kt b/app/core/src/main/java/com/fsck/k9/notification/BaseNotificationDataCreator.kt
index 443091bd8dd..936f884c4dd 100644
--- a/app/core/src/main/java/com/fsck/k9/notification/BaseNotificationDataCreator.kt
+++ b/app/core/src/main/... | diff --git a/app/core/src/test/java/com/fsck/k9/notification/BaseNotificationDataCreatorTest.kt b/app/core/src/test/java/com/fsck/k9/notification/BaseNotificationDataCreatorTest.kt
index 3ba7af999b5..5b0cf007a33 100644
--- a/app/core/src/test/java/com/fsck/k9/notification/BaseNotificationDataCreatorTest.kt
+++ b/app/co... | {
"com.fsck.k9.notification.NewMailNotificationManagerTest.remove last remaining notification": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {
"com.fsck.k9.notification.NewMailNotificationManagerTest.remove notification when additional notifications are available": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.notification.NewMailNotificationManagerTest.add one more notification when already displaying the maximum number o... | {} | {} |
thunderbird__thunderbird-android-5765 | thunderbird | thunderbird-android | 5,765 | closed | Properly decode multiple encoded-words using ISO-2022-JP | Add special support for ISO-2022-JP when decoding encoded-words.
Fixes #5760 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "3887681d58d986a0c1c281df76163a5f7d9cf0f5"
} | [
{
"number": 5760,
"title": "`◆?` charcter appears in the subject when it has multiple MIME lines",
"body": "**Describe the bug**\r\n\r\nGraphical character (`◆` + `?`) appears in the subject of some mails written in Japanese language.\r\n\r\n**To Reproduce**\r\n\r\nPost a mail with subject like:\r\n```... | kotlin | `◆?` charcter appears in the subject when it has multiple MIME lines
**Describe the bug**
Graphical character (`◆` + `?`) appears in the subject of some mails written in Japanese language.
**To Reproduce**
Post a mail with subject like:
```
Subject: =?ISO-2022-JP?B?GyRCRnxLXDhsJEhGfEtcOGwkSEZ8S1w4bCROJUElJy... | Works for me when copying the text from your post. It's possible the actual email contains additional invisible characters. Can you attach the unmodified source of such a message?
Sure, atached.
[issue5760-mail.zip](https://github.com/k9mail/k-9/files/7447799/issue5760-mail.zip)
Apologies. Decoding the subject worke... | https://github.com/thunderbird/thunderbird-android/pull/5765 | [
"https://github.com/thunderbird/thunderbird-android/issues/5760"
] | ./gradlew :mail:common:testDebugUnitTest --tests "com.fsck.k9.mail.internet.DecoderUtilTest" | diff --git a/mail/common/build.gradle b/mail/common/build.gradle
index 5711d6feb01..0e4c627e45e 100644
--- a/mail/common/build.gradle
+++ b/mail/common/build.gradle
@@ -19,6 +19,7 @@ dependencies {
testImplementation "com.google.truth:truth:${versions.truth}"
testImplementation "org.mockito:mockito-core:${ver... | diff --git a/mail/common/src/test/java/com/fsck/k9/mail/internet/DecoderUtilTest.java b/mail/common/src/test/java/com/fsck/k9/mail/internet/DecoderUtilTest.java
index b1f077573ba..e5c027b71fb 100644
--- a/mail/common/src/test/java/com/fsck/k9/mail/internet/DecoderUtilTest.java
+++ b/mail/common/src/test/java/com/fsck/k... | {
"com.fsck.k9.mail.internet.DecoderUtilTest.decodeEncodedWords_withMultipleEncodedSections_decodesBoth": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.internet.DecoderUtilTest.decodeEncodedWords_withUnrecognisedEncoding_withEncodedData_return_encoded_data": {
"run": "PASS",
... | {} | {} | {} |
tuskyapp__Tusky-4993 | tuskyapp | Tusky | 4,993 | closed | fix loading posts with invalid `published_at` in preview card | closes #4992 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "271514f2ce5f57fc01aa1e9987e18fbeb0dad684"
} | [
{
"number": 4992,
"title": "Trending posts no longer load",
"body": "Trending posts stopped loading in the beta. They still load fine in browser for my instance \n\n\nApp details:\n\n... | kotlin | Trending posts no longer load
Trending posts stopped loading in the beta. They still load fine in browser for my instance 
App details:
Tusky 28.0 beta 1
Device:
asus ASUS_AI2401_H
Android versi... | There is a post where the preview card has an invalid `published_at` date currently trending https://github.com/mastodon/mastodon/issues/34182
@cbeyls Do you have an idea what a good client side fix for this is? Combining `GuardedAdapter` with `Rfc3339DateJsonAdapter` doesn't seem to work :(
`GuardedAdapter` skips the ... | https://github.com/tuskyapp/Tusky/pull/4993 | [
"https://github.com/tuskyapp/Tusky/issues/4992"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.json.GuardedAdapterTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/di/NetworkModule.kt b/app/src/main/java/com/keylesspalace/tusky/di/NetworkModule.kt
index 2a81d55ebd..d7d16fcf2d 100644
--- a/app/src/main/java/com/keylesspalace/tusky/di/NetworkModule.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/di/NetworkModule.kt
@@ -82,8 ... | diff --git a/app/src/test/java/com/keylesspalace/tusky/json/GuardedAdapterTest.kt b/app/src/test/java/com/keylesspalace/tusky/json/GuardedAdapterTest.kt
index 87ae8e5f59..5dfaef991a 100644
--- a/app/src/test/java/com/keylesspalace/tusky/json/GuardedAdapterTest.kt
+++ b/app/src/test/java/com/keylesspalace/tusky/json/Gua... | {
"com.keylesspalace.tusky.json.GuardedAdapterTest.should deserialize PreviewCard when attribute 'published_at' is invalid": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.json.GuardedAdapterTest.should deserialize Relationship when attribute 'subscribing' is an object": {
... | {
"com.keylesspalace.tusky.json.GuardedAdapterTest.should deserialize Relationship when attribute 'subscribing' does not exist": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
tuskyapp__Tusky-4821 | tuskyapp | Tusky | 4,821 | closed | fix "delete all notifications by user" query | The brackets were at the wrong position and notification types are actually serialized differently.
Closes #4817 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "55467affc811a430f983735dcc79ad71f628cd70"
} | [
{
"number": 4817,
"title": "Blocked users remain in notifications",
"body": "### Detailed description\n\nAfter blocking a user, notifications from or about that user should be removed or hidden.\n\n### Steps to reproduce the problem\n\nActual behavior: \r\n\r\n* I received a notification of a new follow... | kotlin | Blocked users remain in notifications
### Detailed description
After blocking a user, notifications from or about that user should be removed or hidden.
### Steps to reproduce the problem
Actual behavior:
* I received a notification of a new follower
* I examine their profile and determined it was a spam accoun... | null | https://github.com/tuskyapp/Tusky/pull/4821 | [
"https://github.com/tuskyapp/Tusky/issues/4817"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.db.dao.NotificationsDaoTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/db/dao/NotificationsDao.kt b/app/src/main/java/com/keylesspalace/tusky/db/dao/NotificationsDao.kt
index e429dc20e3..9029ae7602 100644
--- a/app/src/main/java/com/keylesspalace/tusky/db/dao/NotificationsDao.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/db/dao/N... | diff --git a/app/src/test/java/com/keylesspalace/tusky/db/dao/NotificationsDaoTest.kt b/app/src/test/java/com/keylesspalace/tusky/db/dao/NotificationsDaoTest.kt
index 4a19aa0e0b..e3c14ad6a2 100644
--- a/app/src/test/java/com/keylesspalace/tusky/db/dao/NotificationsDaoTest.kt
+++ b/app/src/test/java/com/keylesspalace/tu... | {
"com.keylesspalace.tusky.db.dao.NotificationsDaoTest.insertAndGetNotification": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.db.dao.NotificationsDaoTest.deleteRange": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.db.dao.Notif... | {
"com.keylesspalace.tusky.db.dao.NotificationsDaoTest.should return null as topId when db is empty": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.keylesspalace.tusky.db.dao.NotificationsDaoTest.should return correct top placeholderId": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.keylesspalace.tusky.db.dao.NotificationsDaoTest.should return correct topId": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.k... | {} |
tuskyapp__Tusky-4642 | tuskyapp | Tusky | 4,642 | closed | Fix detecting urls | closes #4641 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "49fbe1f408102e70e6f52bd969974f971b37b547"
} | [
{
"number": 4641,
"title": "Tusky URL detection breaks if capital letters in scheme://",
"body": "### Steps to reproduce the problem\r\n\r\n1. Open Compose in Mastodon Web on PC, and Tusky side by side.\r\n2. In both, type: `Https://example.com` or `HTTPS://EXAMPLE.COM`\r\n\r\n**Expected behavior:** Mas... | kotlin | Tusky URL detection breaks if capital letters in scheme://
### Steps to reproduce the problem
1. Open Compose in Mastodon Web on PC, and Tusky side by side.
2. In both, type: `Https://example.com` or `HTTPS://EXAMPLE.COM`
**Expected behavior:** Mastodon Web and Tusky should have identical behavior.
**Observed... | null | https://github.com/tuskyapp/Tusky/pull/4642 | [
"https://github.com/tuskyapp/Tusky/issues/4641"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.SpanUtilsTest" --tests "com.keylesspalace.tusky.components.compose.StatusLengthTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/util/SpanUtils.kt b/app/src/main/java/com/keylesspalace/tusky/util/SpanUtils.kt
index 0a6b1ca00e..4da9b16d46 100644
--- a/app/src/main/java/com/keylesspalace/tusky/util/SpanUtils.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/util/SpanUtils.kt
@@ -66,7 +66,7 @@... | diff --git a/app/src/test/java/com/keylesspalace/tusky/SpanUtilsTest.kt b/app/src/test/java/com/keylesspalace/tusky/SpanUtilsTest.kt
index 6d12f7634b..7a369d7bb2 100644
--- a/app/src/test/java/com/keylesspalace/tusky/SpanUtilsTest.kt
+++ b/app/src/test/java/com/keylesspalace/tusky/SpanUtilsTest.kt
@@ -115,6 +115,10 @@ ... | {
"com.keylesspalace.tusky.SpanUtilsTest.testHighlighting[Test https://test.xyz/blubbtest)))))))))))]": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.SpanUtilsTest.testHighlighting[((#Test))]": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylessp... | {
"com.keylesspalace.tusky.SpanUtilsTest.testHighlighting[@mention]": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.compose.StatusLengthTest.statusLength_withCwText_matchesExpectations[Http://example.org]": {
"run": "NONE",
"test": "FAIL",
"fix": "PA... | {} | {} |
tuskyapp__Tusky-4638 | tuskyapp | Tusky | 4,638 | closed | fix crash when there are reblogs in notification statuses | ```
android.database.sqlite.SQLiteConstraintException: FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY)
at android.database.sqlite.SQLiteConnection.nativeExecuteForLastInsertedRowId(Native Method)
at android.database.sqlite.SQLiteConnection.executeForLastInsertedRowId(SQLiteConnection.ja... | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "da54cda88ecc855998eed574862bf07454e0c882"
} | [
{
"number": 4563,
"title": "Tusky 26: Repeated force-close in notifications view (Friendica)",
"body": "### Detailed description\n\nUnsure how to completely reproduce or describe this: Been using Tusky with Friendica quite reliably for white a while now, but with the 26 (Google Play) release this has tu... | kotlin | Tusky 26: Repeated force-close in notifications view (Friendica)
### Detailed description
Unsure how to completely reproduce or describe this: Been using Tusky with Friendica quite reliably for white a while now, but with the 26 (Google Play) release this has turned pretty unstable. Observations:
- Notifications do... | What kind of notifications do you have? Any that are very unusual / friendica specific? I tried reproducing this on my opensocial.at account with a bunch of mentions and likes and it works just fine.
To be honest: I'm not sure. Just the "usual stuff" I guess. Some comments, some likes. Nothing I'd see as specific or su... | https://github.com/tuskyapp/Tusky/pull/4638 | [
"https://github.com/tuskyapp/Tusky/issues/4563"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.components.notifications.NotificationsRemoteMediatorTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationTypeMappers.kt b/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationTypeMappers.kt
index d3248a6720..0ad4deffca 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/notifications/Notifica... | diff --git a/app/src/test/java/com/keylesspalace/tusky/components/notifications/NotificationsRemoteMediatorTest.kt b/app/src/test/java/com/keylesspalace/tusky/components/notifications/NotificationsRemoteMediatorTest.kt
index 0f2c9abb43..34ae432bb1 100644
--- a/app/src/test/java/com/keylesspalace/tusky/components/notifi... | {
"com.keylesspalace.tusky.components.notifications.NotificationsRemoteMediatorTest.should refresh and not insert placeholders when there is overlap with existing notifications": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.notifications.NotificationsRemoteMedi... | {
"com.keylesspalace.tusky.components.notifications.NotificationsRemoteMediatorTest.should append notifications": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.keylesspalace.tusky.components.notifications.NotificationsRemoteMediatorTest.should refresh and insert placeholder when a whole page with no overlap to existing notifications is loaded": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.notifications.Notifica... | {} |
tuskyapp__Tusky-4599 | tuskyapp | Tusky | 4,599 | closed | prevent mixup of account timelines | This does 2 things:
- Removes `AccountSwitchInterceptor`, the main culprit for the bug. APIs can no longer change their base url after they have been created. As a result they are not Singletons anymore.
- Additionally, I refactored how MainActivity handles Intents to make it less likely to have multiple instances ... | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "9abf02a6c52aa1d915c7d416fa67991bda731df8"
} | [
{
"number": 4148,
"title": "With multiple accounts, sometimes the wrong home timeline is shown",
"body": "I have experienced a problem with multiple accounts set up in Tusky where after switching from account 2 (pixelfed) to account 1 (mastodon), the home timeline of account 2 (pixelfed) would be shown ... | kotlin | With multiple accounts, sometimes the wrong home timeline is shown
I have experienced a problem with multiple accounts set up in Tusky where after switching from account 2 (pixelfed) to account 1 (mastodon), the home timeline of account 2 (pixelfed) would be shown and even after switching back and forth between account... |
Possibly related to https://github.com/tuskyapp/Tusky/issues/4402 but somewhat different symptoms
Thank you so much for the info, we are aware of the issue and trying to find out what's happening
Thank you so much for the info, we are investigating!
related: #4554 #4402
Just wanted to verify, on closer inspection t... | https://github.com/tuskyapp/Tusky/pull/4599 | [
"https://github.com/tuskyapp/Tusky/issues/4148",
"https://github.com/tuskyapp/Tusky/issues/4554",
"https://github.com/tuskyapp/Tusky/issues/4567",
"https://github.com/tuskyapp/Tusky/issues/2663",
"https://github.com/tuskyapp/Tusky/issues/4402"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.network.InstanceSwitchAuthInterceptorTest" --tests "com.keylesspalace.tusky.network.RetrofitApiTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/MainActivity.kt b/app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
index 894757a79e..787f78ef5e 100644
--- a/app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
@@ -363,6 +363,11 @@ clas... | diff --git a/app/src/test/java/com/keylesspalace/tusky/network/InstanceSwitchAuthInterceptorTest.kt b/app/src/test/java/com/keylesspalace/tusky/network/InstanceSwitchAuthInterceptorTest.kt
deleted file mode 100644
index 206e27d5ca..0000000000
--- a/app/src/test/java/com/keylesspalace/tusky/network/InstanceSwitchAuthInt... | {
"com.keylesspalace.tusky.network.RetrofitApiTest.should make request to instance requested in special header when account active": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.network.RetrofitApiTest.should fail when current instance is requested but no user is logged i... | {} | {} | {} |
tuskyapp__Tusky-4152 | tuskyapp | Tusky | 4,152 | closed | correctly count emojis when composing a post | Thx to @evant for the help
closes #4140 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "a7e0fa26b7ba60ce996cf6e19c9b496750b1b1d4"
} | [
{
"number": 4140,
"title": "emoji character count",
"body": "[Issue text goes here].\r\n\r\n* * * *\r\n- Tusky Version: 23\r\n- Android Version: 13\r\n- Android Device: Xiaomi note 10 pro\r\n- Mastodon instance (if applicable): mastodon.uno\r\n\r\n- [x ] I searched or browsed the repo’s other issues to ... | kotlin | emoji character count
[Issue text goes here].
* * * *
- Tusky Version: 23
- Android Version: 13
- Android Device: Xiaomi note 10 pro
- Mastodon instance (if applicable): mastodon.uno
- [x ] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
When I use an emoji inside a toot it... | null | https://github.com/tuskyapp/Tusky/pull/4152 | [
"https://github.com/tuskyapp/Tusky/issues/4140"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.components.compose.ComposeTokenizerTest" --tests "com.keylesspalace.tusky.components.compose.ComposeActivityTest" --tests "com.keylesspalace.tusky.components.compose.StatusLengthTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/components/compose/ComposeActivity.kt b/app/src/main/java/com/keylesspalace/tusky/components/compose/ComposeActivity.kt
index a87b60f587..0ee91e48f6 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/compose/ComposeActivity.kt
+++ b/app/src/main/java... | diff --git a/app/src/test/java/com/keylesspalace/tusky/components/compose/ComposeActivity/ComposeActivityTest.kt b/app/src/test/java/com/keylesspalace/tusky/components/compose/ComposeActivityTest.kt
similarity index 94%
rename from app/src/test/java/com/keylesspalace/tusky/components/compose/ComposeActivity/ComposeActi... | {
"com.keylesspalace.tusky.components.compose.StatusLengthTest.statusLength_matchesExpectations[ ]": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.compose.ComposeActivityTest.whenTextContainsUrl_onlyEllipsizedURLIsCounted_withCustomConfigurationV1": {
"run":... | {
"com.keylesspalace.tusky.components.compose.StatusLengthTest.statusLength_withCwText_matchesExpectations[🫣]": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.compose.ComposeActivityTest.languageGivenInComposeOptionsIsRespected": {
"run": "NONE",
... | {
"com.keylesspalace.tusky.components.compose.ComposeActivityTest.whenBackButtonPressedNotEmpty_notFinish": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.compose.ComposeTokenizerTest.tokenIndices_matchExpectations[@:mastodon]": {
"run": "NONE",
"test": "... | {} |
tuskyapp__Tusky-4103 | tuskyapp | Tusky | 4,103 | closed | Fix deserialization of the response from friendica on api/v2/instance | Fixes #4100 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "e9195846825a24985bd27c866eb4277ea82b7748"
} | [
{
"number": 4100,
"title": "[friendica] Post length limited to 500 in recent Friendica RC",
"body": "Using Tusky Test 23.0-e9195846 with Friendica 2023.09-rc on loma.ml, I noticed that all of a sudden I can't compose posts longer than 500 chars anymore. Current Tusky stable does however display the \"co... | kotlin | [friendica] Post length limited to 500 in recent Friendica RC
Using Tusky Test 23.0-e9195846 with Friendica 2023.09-rc on loma.ml, I noticed that all of a sudden I can't compose posts longer than 500 chars anymore. Current Tusky stable does however display the "correct" amount of chars allowed per post (around 20k on t... | My instinct is that it's a regression caused by [instance v2 support](https://github.com/tuskyapp/Tusky/pull/4062), in particular I notice that https://loma.ml/api/v2/instance fails to return a number of fields in `configuration` that I understood to be "mandatory" from the mastodon api docs
I'll investigate | https://github.com/tuskyapp/Tusky/pull/4103 | [
"https://github.com/tuskyapp/Tusky/issues/4100"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.components.compose.ComposeActivity.ComposeActivityTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/components/instanceinfo/InstanceInfoRepository.kt b/app/src/main/java/com/keylesspalace/tusky/components/instanceinfo/InstanceInfoRepository.kt
index 4031181ed2..c781ff90e3 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/instanceinfo/InstanceInfoR... | diff --git a/app/src/test/java/com/keylesspalace/tusky/components/compose/ComposeActivity/ComposeActivityTest.kt b/app/src/test/java/com/keylesspalace/tusky/components/compose/ComposeActivity/ComposeActivityTest.kt
index ecff6d3be5..451b5c09a0 100644
--- a/app/src/test/java/com/keylesspalace/tusky/components/compose/Co... | {
"com.keylesspalace.tusky.components.compose.ComposeActivity.ComposeActivityTest.whenTextContainsUrl_onlyEllipsizedURLIsCounted": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.compose.ComposeActivity.ComposeActivityTest.whenOnlyConfigurationMaximumTootCharsIsPo... | {} | {} | {} |
tuskyapp__Tusky-3448 | tuskyapp | Tusky | 3,448 | closed | Show better errors when loading notifications fails | The errors are returned as a JSON object, parse it, and show the error message it contains.
Handle the cases where there might be no error message, or the JSON may be malformed.
Add tests.
Fixes #3445 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "3bb92d51bf8331c57ed2a24f3f816039ad641e19"
} | [
{
"number": 3445,
"title": "Error message handling for notifications still needs work",
"body": "https://github.com/tuskyapp/Tusky/pull/3440 displayed error text when notifications fail to load because of the server, but the presentation of that can still be improved. I caught an error from mastodon.soc... | kotlin | Error message handling for notifications still needs work
https://github.com/tuskyapp/Tusky/pull/3440 displayed error text when notifications fail to load because of the server, but the presentation of that can still be improved. I caught an error from mastodon.social a moment ago, and it currently looks like this:
... | null | https://github.com/tuskyapp/Tusky/pull/3448 | [
"https://github.com/tuskyapp/Tusky/issues/3445"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.components.notifications.NotificationsPagingSourceTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsPagingSource.kt b/app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsPagingSource.kt
index 90d24fed94..5f7eafb0ef 100644
--- a/app/src/main/java/com/keylesspalace/tusky/components/notifications/Noti... | diff --git a/app/src/test/java/com/keylesspalace/tusky/components/notifications/NotificationsPagingSourceTest.kt b/app/src/test/java/com/keylesspalace/tusky/components/notifications/NotificationsPagingSourceTest.kt
new file mode 100644
index 0000000000..450f702a7c
--- /dev/null
+++ b/app/src/test/java/com/keylesspalace... | {
"com.keylesspalace.tusky.components.notifications.NotificationsPagingSourceTest.load() returns error message on HTTP error": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.components.notifications.NotificationsPagingSourceTest.load() returns useful error message on malfor... | {} | {} | {} |
tuskyapp__Tusky-3341 | tuskyapp | Tusky | 3,341 | closed | When looking up fediverse urls, verify that account results returned match the input query | Fixes #2804 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "52c98749e6a0dff52c4c06ec82baa7e95ce49b42"
} | [
{
"number": 2804,
"title": "Link lookup ends up with wrong link",
"body": "I have been using Tusky for a good week now and noticed that every now and then clicking on links in posts take me to the wrong internet address.\r\n\r\nE.g.:\r\n1. Click a link in a post, which should go to www.patrion.com/…\r\n... | kotlin | Link lookup ends up with wrong link
I have been using Tusky for a good week now and noticed that every now and then clicking on links in posts take me to the wrong internet address.
E.g.:
1. Click a link in a post, which should go to www.patrion.com/…
2. Land on the Mastodon profile of the European Commision?
A b... | Is the account of the European commission involved or mentioned in this thread? Does it happen only in thread view or also in other places?
Also, which instance are you on?
> Is the account of the European commission involved or mentioned in this thread? Does it happen only in thread view or also in other places?
N... | https://github.com/tuskyapp/Tusky/pull/3341 | [
"https://github.com/tuskyapp/Tusky/issues/2804"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.BottomSheetActivityTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.kt b/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.kt
index 60d1966d1c..8df0c66171 100644
--- a/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.... | diff --git a/app/src/test/java/com/keylesspalace/tusky/BottomSheetActivityTest.kt b/app/src/test/java/com/keylesspalace/tusky/BottomSheetActivityTest.kt
index 66b922bd5a..f4b12a61f0 100644
--- a/app/src/test/java/com/keylesspalace/tusky/BottomSheetActivityTest.kt
+++ b/app/src/test/java/com/keylesspalace/tusky/BottomSh... | {} | {
"com.keylesspalace.tusky.BottomSheetActivityTest.search_doesNotRespectUnrelatedResult": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.keylesspalace.tusky.BottomSheetActivityTest.search_withPreviousCancellation_completes": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.keylesspalace.tusky.BottomSheetActivityTest.beginEndSearch_setIsSearching_doesNotCancelSearchWhenResponseFromPreviousSearchIsReceived": {
"run": "PA... | {} |
tuskyapp__Tusky-2945 | tuskyapp | Tusky | 2,945 | closed | Load goto social and microblog.pub urls in the app | - goto social status urls
- goto social profile urls
- microblog.pub status urls
(microblog.pub profile urls are just site urls, so 🤷 )
I also moved the utility function into `LinkHelper`, it felt weird to keep it in `BottomSheetActivity`
#2893 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "8437fbd60513ec5279502e59ff0a02e3c5605611"
} | [
{
"number": 2893,
"title": "Missing support for GoToSocial and microblog.pub links in looksLikeMastodonUrl",
"body": "Tusky currently supports automated lookup of posts (i.e., URLs inside other posts) from Mastodon, Pleroma, Friendica, Misskey, and Pixelfed, but it fails when it comes to [GoToSocial](ht... | kotlin | Missing support for GoToSocial and microblog.pub links in looksLikeMastodonUrl
Tusky currently supports automated lookup of posts (i.e., URLs inside other posts) from Mastodon, Pleroma, Friendica, Misskey, and Pixelfed, but it fails when it comes to [GoToSocial](https://gotosocial.org/) or [microblog.pub](https://docs.... | null | https://github.com/tuskyapp/Tusky/pull/2945 | [
"https://github.com/tuskyapp/Tusky/issues/2893"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.BottomSheetActivityTest" --tests "com.keylesspalace.tusky.util.LinkHelperTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.kt b/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.kt
index 36a476f2fb..60d1966d1c 100644
--- a/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/BottomSheetActivity.... | diff --git a/app/src/test/java/com/keylesspalace/tusky/BottomSheetActivityTest.kt b/app/src/test/java/com/keylesspalace/tusky/BottomSheetActivityTest.kt
index 4c77799976..142893cee7 100644
--- a/app/src/test/java/com/keylesspalace/tusky/BottomSheetActivityTest.kt
+++ b/app/src/test/java/com/keylesspalace/tusky/BottomSh... | {
"com.keylesspalace.tusky.util.LinkHelperTest.hiddenDomainsAreMarkedUp": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.BottomSheetActivityTest.search_withNoResults_appliesRequestedFallbackBehavior": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.ke... | {} | {} | {} |
tuskyapp__Tusky-2757 | tuskyapp | Tusky | 2,757 | closed | Navigate to the Follow Requests page from notification | Fixes #2655 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "8e9b356074e961c483bb5f64833efcd03e2a3ab7"
} | [
{
"number": 2655,
"title": "Pressing \"<user> requested to follow you\" android notification sends user to wrong UI",
"body": "Pressing \"<user> requested to follow you\" android notification doesn't present the user with the \"Follow Requests\" UI. Instead, it presents it with the \"Notifications\" UI,... | kotlin | Pressing "<user> requested to follow you" android notification sends user to wrong UI
Pressing "<user> requested to follow you" android notification doesn't present the user with the "Follow Requests" UI. Instead, it presents it with the "Notifications" UI, but I'm not sure this is always the case, it could be another ... | Hi, just wanted to bump this issue back up, this issue makes me shake my head far too often, even after using Tusky for almost 3 years now. :/ | https://github.com/tuskyapp/Tusky/pull/2757 | [
"https://github.com/tuskyapp/Tusky/issues/2655"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.MainActivityTest" | diff --git a/app/build.gradle b/app/build.gradle
index bc60e65332..12699fb1da 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -146,6 +146,7 @@ dependencies {
testImplementation libs.mockwebserver
testImplementation libs.androidx.core.testing
testImplementation libs.kotlinx.coroutines.test
+ te... | diff --git a/app/src/test/java/com/keylesspalace/tusky/MainActivityTest.kt b/app/src/test/java/com/keylesspalace/tusky/MainActivityTest.kt
new file mode 100644
index 0000000000..1414245551
--- /dev/null
+++ b/app/src/test/java/com/keylesspalace/tusky/MainActivityTest.kt
@@ -0,0 +1,130 @@
+package com.keylesspalace.tusk... | {
"com.keylesspalace.tusky.MainActivityTest.clicking notification of type FOLLOW_REQUEST shows follow requests": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.MainActivityTest.clicking notification of type FOLLOW shows notification tab": {
"run": "NONE",
"test": "N... | {} | {} | {} |
tuskyapp__Tusky-2713 | tuskyapp | Tusky | 2,713 | closed | Parse html tags out of status content before applying filters | Fixes #2660 | {
"label": "tuskyapp:develop",
"ref": "develop",
"sha": "91d18998acac2116010d191922a8d61455243cf7"
} | [
{
"number": 2660,
"title": "Filters with Hashtags not working",
"body": "I think we had this issue in the past, but here it is again. :)\r\n\r\nA filter for a hastag:\r\n\r\n\r\n\r\nIt works in... | kotlin | Filters with Hashtags not working
I think we had this issue in the past, but here it is again. :)
A filter for a hastag:
It works in web:
![image](https://user-images.githubusercontent.com/4251138... | null | https://github.com/tuskyapp/Tusky/pull/2713 | [
"https://github.com/tuskyapp/Tusky/issues/2660"
] | ./gradlew :app:testBlueDebugUnitTest --tests "com.keylesspalace.tusky.FilterTest" | diff --git a/app/src/main/java/com/keylesspalace/tusky/network/FilterModel.kt b/app/src/main/java/com/keylesspalace/tusky/network/FilterModel.kt
index db47beaf08..16a439d950 100644
--- a/app/src/main/java/com/keylesspalace/tusky/network/FilterModel.kt
+++ b/app/src/main/java/com/keylesspalace/tusky/network/FilterModel.... | diff --git a/app/src/test/java/com/keylesspalace/tusky/FilterTest.kt b/app/src/test/java/com/keylesspalace/tusky/FilterTest.kt
index b28f6c9a07..b8ca181e9f 100644
--- a/app/src/test/java/com/keylesspalace/tusky/FilterTest.kt
+++ b/app/src/test/java/com/keylesspalace/tusky/FilterTest.kt
@@ -53,6 +53,14 @@ class FilterTe... | {
"com.keylesspalace.tusky.FilterTest.shouldFilterHashtags": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.FilterTest.unchangedExpiration_shouldBePositive_whenFilterIsUnexpired": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.keylesspalace.tusky.Fil... | {
"com.keylesspalace.tusky.FilterTest.shouldFilter_whenMediaDescriptionDoesMatch": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.keylesspalace.tusky.FilterTest.shouldNotFilter_whenContentDoesNotMatchWholeWord": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
PaulWoitaschek__Voice-3134 | PaulWoitaschek | Voice | 3,134 | closed | Improve the Search Logic | Fixes #3132.
While the copilot pull request is a good approach, this one includes more sophisticated unit tests together with `BookFactory` adjustments to search for the new fields `genre`, `narrator`, `series` and `part`. The production code is basically the same.
@PaulWoitaschek
A 2 minute review should alrea... | {
"label": "PaulWoitaschek:main",
"ref": "main",
"sha": "875c126c2fccbfc4b174e272d86756c9341df52c"
} | [
{
"number": 3132,
"title": "Search seems to rely on a strange query preparation, that does not seem right?!",
"body": "### Overview\n\nI stumbled over this while trying to search for the new `series` and `part` fields recently added, e.g `Benjamin Blümchen 124`\n\nWhen searching a book, the search query... | kotlin | Search seems to rely on a strange query preparation, that does not seem right?!
### Overview
I stumbled over this while trying to search for the new `series` and `part` fields recently added, e.g `Benjamin Blümchen 124`
When searching a book, the search query is rewritten prepared, to use the `MATCH` keyword in an sq... | Tbh I don't remember. I also recently looked at the implementation and was rather puzzled.
Feel free to drop a few test cases and improve the implementation! | https://github.com/PaulWoitaschek/Voice/pull/3134 | [
"https://github.com/PaulWoitaschek/Voice/issues/3132"
] | ./gradlew :core:search:testDebugUnitTest --tests "voice.core.search.BookSearchTest" | diff --git a/core/search/src/main/kotlin/voice/core/search/BookSearch.kt b/core/search/src/main/kotlin/voice/core/search/BookSearch.kt
index 8bca83d616..cd1dd62cac 100644
--- a/core/search/src/main/kotlin/voice/core/search/BookSearch.kt
+++ b/core/search/src/main/kotlin/voice/core/search/BookSearch.kt
@@ -4,22 +4,25 @@... | diff --git a/core/search/src/test/kotlin/voice/core/search/BookFactory.kt b/core/search/src/test/kotlin/voice/core/search/BookFactory.kt
index 965e02226c..818c8ec3c5 100644
--- a/core/search/src/test/kotlin/voice/core/search/BookFactory.kt
+++ b/core/search/src/test/kotlin/voice/core/search/BookFactory.kt
@@ -14,6 +14,... | {
"voice.core.search.BookSearchTest.search partial word in name from beginning": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"voice.core.search.BookSearchTest.search complete name": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"voice.core.search.BookSearchTest.sql reserved c... | {
"voice.core.search.BookSearchTest.search partial word in name from beginning with whitespace": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"voice.core.search.BookSearchTest.multiple matches on title": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"voice.core.search.BookSearchTest.search single word in author": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
PaulWoitaschek__Voice-3112 | PaulWoitaschek | Voice | 3,112 | closed | Fix the sleep timer | Fixes #3110 | {
"label": "PaulWoitaschek:main",
"ref": "main",
"sha": "9e7cc144a62f63fcd66e1dd0d2c6e3f806810134"
} | [
{
"number": 3110,
"title": "Sleep timer crashes after restarting",
"body": "### Overview\n\nThe sleep timer crashes after restarting by shaking the phone.\n\nI've tested with and without the setting to automatically enable sleep timer. In both cases, the timer (set to 1 minute) crashed with about 35 sec... | kotlin | Sleep timer crashes after restarting
### Overview
The sleep timer crashes after restarting by shaking the phone.
I've tested with and without the setting to automatically enable sleep timer. In both cases, the timer (set to 1 minute) crashed with about 35 seconds (+- 2 sec) left and the audiobook kept playing indefin... | null | https://github.com/PaulWoitaschek/Voice/pull/3112 | [
"https://github.com/PaulWoitaschek/Voice/issues/3110"
] | ./gradlew :core:sleeptimer:impl:testDebugUnitTest --tests "voice.core.sleeptimer.impl.SleepTimerImplTest" | diff --git a/core/sleeptimer/impl/src/main/kotlin/voice/core/sleeptimer/ShakeDetector.kt b/core/sleeptimer/impl/src/main/kotlin/voice/core/sleeptimer/ShakeDetector.kt
index 075f203300..b1ffcb22af 100644
--- a/core/sleeptimer/impl/src/main/kotlin/voice/core/sleeptimer/ShakeDetector.kt
+++ b/core/sleeptimer/impl/src/main... | diff --git a/core/sleeptimer/impl/src/test/kotlin/voice/core/sleeptimer/impl/SleepTimerImplTest.kt b/core/sleeptimer/impl/src/test/kotlin/voice/core/sleeptimer/impl/SleepTimerImplTest.kt
index 436f71cfc4..21ee4fbc22 100644
--- a/core/sleeptimer/impl/src/test/kotlin/voice/core/sleeptimer/impl/SleepTimerImplTest.kt
+++ b... | {
"voice.core.sleeptimer.impl.SleepTimerImplTest.enable with EndOfChapter sets state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"voice.core.sleeptimer.impl.SleepTimerImplTest.shake_does_not_cancel_second_countdown_after_window": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
... | {} | {} | {} |
PaulWoitaschek__Voice-2865 | PaulWoitaschek | Voice | 2,865 | closed | fix: Parse mpeg4 chapter tracks correctly | Fixes #2840 | {
"label": "PaulWoitaschek:main",
"ref": "main",
"sha": "292e53cfc1eadf6115ed5a479c992b450ea6284a"
} | [
{
"number": 2840,
"title": "newest version has killed chapters for my entire library",
"body": "### Overview\n\nUser for ~3 years, since the new version the app hasn't been identifying chapters for any of my m4b files, this includes files that previously worked fine on older versions, I've replicated th... | kotlin | newest version has killed chapters for my entire library
### Overview
User for ~3 years, since the new version the app hasn't been identifying chapters for any of my m4b files, this includes files that previously worked fine on older versions, I've replicated the error on 2x pixel phones both running Graphene OS. Thi... | Can confirm that rolling back to 8.3.2 resolves the issue completely
Thanks! Could you send me one file to my mail which previously had chapters but now doesn't?
I'm pinning this issue and will stop the rollout until this is fixed.
If someone could send files which reproduce this issue, that would be really helpful!
I ... | https://github.com/PaulWoitaschek/Voice/pull/2865 | [
"https://github.com/PaulWoitaschek/Voice/issues/2840"
] | ./gradlew :scanner:testDebugUnitTest --tests "voice.app.scanner.MediaAnalyzerTest" | diff --git a/scanner/src/main/kotlin/voice/app/scanner/mp4/ChapterCueProcessor.kt b/scanner/src/main/kotlin/voice/app/scanner/mp4/ChapterCueProcessor.kt
deleted file mode 100644
index 3f7b2f9997..0000000000
--- a/scanner/src/main/kotlin/voice/app/scanner/mp4/ChapterCueProcessor.kt
+++ /dev/null
@@ -1,73 +0,0 @@
-packag... | diff --git a/scanner/src/test/kotlin/voice/app/scanner/MediaAnalyzerTest.kt b/scanner/src/test/kotlin/voice/app/scanner/MediaAnalyzerTest.kt
index 10a6c3a3fc..1ef17b4b49 100644
--- a/scanner/src/test/kotlin/voice/app/scanner/MediaAnalyzerTest.kt
+++ b/scanner/src/test/kotlin/voice/app/scanner/MediaAnalyzerTest.kt
@@ -4... | {
"voice.app.scanner.MediaAnalyzerTest.ogg": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"voice.app.scanner.MediaAnalyzerTest.m4a with chpl chapters": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"voice.app.scanner.MediaAnalyzerTest.opus": {
"run": "PASS",
"test": "N... | {} | {} | {} |
PaulWoitaschek__Voice-1839 | PaulWoitaschek | Voice | 1,839 | closed | Ask for battery optimizations at most three times. | Fixes #1801 | {
"label": "PaulWoitaschek:main",
"ref": "main",
"sha": "0d207222ea81e1ab8beb5d419c7e064354bd76d8"
} | [
{
"number": 1801,
"title": "Dismissing battery optimization toast permanently",
"body": "Version 7.0.6\n\nHello,\n\nMy phone uses the AOSP implementation of battery optimization which respects apps just fine, I don't need to disable it. Voice is kept alive as long as it's playing.\nPlease allow me to ke... | kotlin | Dismissing battery optimization toast permanently
Version 7.0.6
Hello,
My phone uses the AOSP implementation of battery optimization which respects apps just fine, I don't need to disable it. Voice is kept alive as long as it's playing.
Please allow me to keep it from prompting me every I press play.
Your app is lo... | null | https://github.com/PaulWoitaschek/Voice/pull/1839 | [
"https://github.com/PaulWoitaschek/Voice/issues/1801"
] | ./gradlew :playbackScreen:testDebugUnitTest --tests "voice.playbackScreen.batteryOptimization.BatteryOptimizationTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 77e470e25a..6022cdd8bb 100755
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -134,6 +134,7 @@ android {
dependencies {
implementation(projects.strings)
+ implementation(projects.datastore)
implementation(projects.common)
implementatio... | diff --git a/playbackScreen/src/test/kotlin/voice/playbackScreen/batteryOptimization/BatteryOptimizationTest.kt b/playbackScreen/src/test/kotlin/voice/playbackScreen/batteryOptimization/BatteryOptimizationTest.kt
new file mode 100644
index 0000000000..b9024d911a
--- /dev/null
+++ b/playbackScreen/src/test/kotlin/voice/... | {
"voice.playbackScreen.batteryOptimization.BatteryOptimizationTest.requests at most three times": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"voice.playbackScreen.batteryOptimization.BatteryOptimizationTest.does not request when optimizations are ignored": {
"run": "NONE",
"test": "NON... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20925 | wordpress-mobile | WordPress-Android | 20,925 | closed | [Reader] Show "Create Post" FAB in Reader | Fixes #20908
- Implement `reader_floating_button` remote feature flag
- Show the "create" FAB in Reader based on the state of the `reader_floating_button` feature flag
- Add analytics (see #20908 for details)
- Move some FAB/Sheet related code to `MainCreateSheetHelper` for better organization
- Some minor refa... | {
"label": "wordpress-mobile:release/25.0",
"ref": "release/25.0",
"sha": "4f6014a6ff59c80d9233fcd1ba30c6563be3fad5"
} | [
{
"number": 20908,
"title": "[Reader] Show \"Create Post\" FAB in Reader",
"body": "As an initial experiment towards the Quick Post in Reader feature we want to enable the existing \"create content\" FAB (from the My Site page) in the Reader, but only showing \"Create Post\" actions in the bottom sheet.... | kotlin | [Reader] Show "Create Post" FAB in Reader
As an initial experiment towards the Quick Post in Reader feature we want to enable the existing "create content" FAB (from the My Site page) in the Reader, but only showing "Create Post" actions in the bottom sheet.
| Button | Sheet |
|--------|--------|
| ![Image](https:... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20925 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20908"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.main.analytics.MainCreateSheetTrackerTest" --tests "org.wordpress.android.ui.main.utils.MainCreateSheetHelperTest" --tests "org.wordpress.android.viewmodel.main.WPMainActivityViewModelTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index ffb8fa889646..04dd425afdf4 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -154,6 +154,7 @@ android {
buildConfigField "boolean", "READER_TAGS_FEED", "false"
buildConfigField "boolean", "READER_ANNOUNCEMENT_CARD", "... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/main/analytics/MainCreateSheetTrackerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/main/analytics/MainCreateSheetTrackerTest.kt
new file mode 100644
index 000000000000..e2cec7f1df9f
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress/andro... | {
"org.wordpress.android.viewmodel.main.WPMainActivityViewModelTest.requests my site dashboard refresh when requestMySiteDashboardRefresh is called": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.viewmodel.main.WPMainActivityViewModelTest.show feature announcement when it's ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20895 | wordpress-mobile | WordPress-Android | 20,895 | closed | [Reader] Add tracks for text highlight/copy in Post Details body | Fixes #20888
Add tracks to text highlight and copy in Post Details body WebView. For that, I used the same javascript code used on iOS (https://github.com/wordpress-mobile/WordPress-iOS/pull/23251/files#diff-0c87a62d20f4b5ede4c7274c4e990d865a633b92dfe70d702672ee27191613d9) to be able to listen to the appropriate ev... | {
"label": "wordpress-mobile:release/25.0",
"ref": "release/25.0",
"sha": "43d396355a64f31d16a37b1119b1d043d479d48b"
} | [
{
"number": 20888,
"title": "[Reader] Track how many people select text content in Post Details",
"body": "In order to move forward with the content annotating proposal, we need to start tracking how many people select text content in the Reader and how many copy it. Ref: p1716377347554169-slack-C06D0RN... | kotlin | [Reader] Track how many people select text content in Post Details
In order to move forward with the content annotating proposal, we need to start tracking how many people select text content in the Reader and how many copy it. Ref: p1716377347554169-slack-C06D0RNJG11
iOS issue: https://github.com/wordpress-mobile/W... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20895 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20888"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderPostDetailViewModelTest" | diff --git a/WordPress/src/jetpack/assets/reader_text_events.js b/WordPress/src/jetpack/assets/reader_text_events.js
new file mode 100644
index 000000000000..68cc132b5eeb
--- /dev/null
+++ b/WordPress/src/jetpack/assets/reader_text_events.js
@@ -0,0 +1,26 @@
+/*
+ * wvHandler is the name of the message handler in the w... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderPostDetailViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderPostDetailViewModelTest.kt
index a2a7ea471207..ee39aae42d1c 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/vie... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderPostDetailViewModelTest.ui state shows empty state on failure and no cached data": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderPostDetailViewModelTest.given no network, when post is fetched, the... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20860 | wordpress-mobile | WordPress-Android | 20,860 | closed | [Tags Feed] Update feed tags as Diff, keeping existing tag content | Fixes #20811
When a new `onTagsChanged` is called and the current UI State is `Loaded`, let's just update the tags list and keep any content we already fetched before, by:
- Removing rows from tags that are not in the new call
- Adding rows for tags in the new call in the appropriate position, in the Initial state... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "5bbddf000745f93ce39bafb7b9e21daf1cf8d103"
} | [
{
"number": 20811,
"title": "[Reader] Update only tags that changed instead of the whole list in \"Your Tags\" feed",
"body": "Currently we're updating the whole \"Your Tags\" list when the subscribed status of one tag changes. We should only update the subscribed/unsubscribed tag item instead ([see he... | kotlin | [Reader] Update only tags that changed instead of the whole list in "Your Tags" feed
Currently we're updating the whole "Your Tags" list when the subscribed status of one tag changes. We should only update the subscribed/unsubscribed tag item instead ([see here](https://github.com/wordpress-mobile/WordPress-Android/pu... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20860 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20811"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedUiStateMapper.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedUiStateMapper.kt
index cfac4b72a7b1..015a1433aec1 100644
--- a/WordPress/src/main/java/org/wordpress/android... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt
index 83baaa4a6c28..992017556433 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmod... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.given tags fetched and no connection, when refreshing, then show error message": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.given connection off, whe... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20844 | wordpress-mobile | WordPress-Android | 20,844 | closed | [Tags Feed] Fix duplicate tracking in Reader subfilter | Fixes #20814
- Keep a consistent reference to the SubFilterViewModel observers to leverage the existing Observable APIs, which handle duplicate observation, removal, and re-observation in case of multiple observe call and lifecycle state changes
- Fix sending the `reader_filter_sheet_item_selected` when selecting ... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "06d79f64746fbb421ce1e1d7a3c694a6f00b6cef"
} | [
{
"number": 20814,
"title": "[Reader] Fix `reader_filter_sheet_item_selected` tracked multiple times",
"body": "`reader_filter_sheet_item_selected` should be tracked once when the selected filter changes, but it's being tracked multiple times."
}
] | kotlin | [Reader] Fix `reader_filter_sheet_item_selected` tracked multiple times
`reader_filter_sheet_item_selected` should be tracked once when the selected filter changes, but it's being tracked multiple times.
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20844 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20814"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.subfilter.SubFilterViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt
index 474ef518d722..ec1427374780 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt
+++ b/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/subfilter/SubFilterViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/subfilter/SubFilterViewModelTest.kt
index bad452b02fd0..23e3a40f8b30 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/subfilter/SubFilter... | {
"org.wordpress.android.ui.reader.subfilter.SubFilterViewModelTest.when self-hosted user taps empty bottom sheet cta the me page is opened": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.subfilter.SubFilterViewModelTest.onSubfilterSelected set expected readerModeI... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20842 | wordpress-mobile | WordPress-Android | 20,842 | closed | [Tags Feed] Implement no connection state | Fixes #20815
- Implement `NoConnection` state for showing an error message when the Feed is opened without an internet connection
- Initialize the UI State to `Loading` when there is an internet connection
- Avoid refreshing the tags when there's no internet connection (pull-to-refresh and coming back from tag de... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "f5bf3b155c8834abad8a7258f97c1e718488475b"
} | [
{
"number": 20815,
"title": "[Reader] Empty screen shown in tags feed when there's no internet connection",
"body": "When tags feed is first loaded and the user has no internet connection, we're showing an empty screen. We should probably show an error like we do in the other feeds (in case we don't hav... | kotlin | [Reader] Empty screen shown in tags feed when there's no internet connection
When tags feed is first loaded and the user has no internet connection, we're showing an empty screen. We should probably show an error like we do in the other feeds (in case we don't have the tags). We should compare it with iOS.
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20842 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20815"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/bloggingprompts/promptslist/compose/BloggingPromptsListScreen.kt b/WordPress/src/main/java/org/wordpress/android/ui/bloggingprompts/promptslist/compose/BloggingPromptsListScreen.kt
index e499fad2f4b2..a809a3bdc48c 100644
--- a/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt
index 06368089184f..83baaa4a6c28 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmod... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.given tags fetched and no connection, when refreshing, then show error message": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.Should update UI immediat... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20839 | wordpress-mobile | WordPress-Android | 20,839 | closed | [Tags Feed] Implement retry action for error state | Fixes #20823
Implement the retry action by calling the `fetchTag` method for the appropriate tag.
I also adjusted the height of the `Error` item layout, since it was not matching the height from other items, causing the vertical list content to shift.
-----
## To Test:
Suggestion: use the [branch](https:/... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "8255e5b39f30174704c21bd14cb5ac6164fae6b1"
} | [
{
"number": 20823,
"title": "[Tags IA] Implement \"retry\" action for error state",
"body": "Implement the `onRetryClick` action to try re-fetching the posts for the tag."
}
] | kotlin | [Tags IA] Implement "retry" action for error state
Implement the `onRetryClick` action to try re-fetching the posts for the tag.
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20839 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20823"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedUiStateMapper.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedUiStateMapper.kt
index 283341978ef4..cfac4b72a7b1 100644
--- a/WordPress/src/main/java/org/wordpress/android... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt
index d939380018e5..06368089184f 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmod... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.Should update UI immediately when like button is tapped": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.Should send update like status request when like... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20781 | wordpress-mobile | WordPress-Android | 20,781 | closed | Avoid tracking page accessed on static posters in the WP app | Fixes #20780
This PR fixes an issue in the WP app where we track notifications and reader accessed events even if we are showing a Jetpack static poster.
Didn't go with a deep refactor but extracted some needed logic into a helper method in `JetpackFeatureRemovalPhaseHelper.kt` and added a minimal set of unit tes... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "400df84278f796e2638f14ff71e9115f9062cf59"
} | [
{
"number": 20780,
"title": "Notifications and reader accessed events tracked in WP app when static posters shown.",
"body": "### Expected behavior\r\nIn the WP app, when a user accesses the notifications or reader and the static poster about the Jetpack app is shown, we should not track the \"_accessed... | kotlin | Notifications and reader accessed events tracked in WP app when static posters shown.
### Expected behavior
In the WP app, when a user accesses the notifications or reader and the static poster about the Jetpack app is shown, we should not track the "_accessed" event for that screen.
### Actual behavior
In the WP ... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20781 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20780"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.jetpackoverlay.JetpackFeatureRemovalPhaseHelperTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/jetpackoverlay/JetpackFeatureRemovalPhaseHelper.kt b/WordPress/src/main/java/org/wordpress/android/ui/jetpackoverlay/JetpackFeatureRemovalPhaseHelper.kt
index 77f8d6512f34..1d353a18b1ca 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/jetpackove... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/jetpackoverlay/JetpackFeatureRemovalPhaseHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/jetpackoverlay/JetpackFeatureRemovalPhaseHelperTest.kt
index 9c982182aeb8..6f463f5536e7 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/je... | {
"org.wordpress.android.ui.jetpackoverlay.JetpackFeatureRemovalPhaseHelperTest.given phase four config true, when current site creation phase is fetched, then return phase two": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.jetpackoverlay.JetpackFeatureRemovalPhaseHelper... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20769 | wordpress-mobile | WordPress-Android | 20,769 | closed | Update "Followers" terminology to "Subscribers" | Fixes #20690
This PR updates `followers` and `follows` terminology in the app to `subscribers`. Text related to following tags or conversations should not be affected, as well as any other usage of `follow` that doesn't fit within the `subscribers` context.
-----
## To Test:
1. To test, check `Stats`, `Notific... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "400df84278f796e2638f14ff71e9115f9062cf59"
} | [
{
"number": 20690,
"title": "Update terminology to Subscribers from Followers",
"body": "Full Scope: https://github.com/Automattic/wordpress-mobile/issues/47\r\nDesign: [IqhXWz3Iir7RMb5XH5gGfZ-fi-883%3A4006](https://href.li/?https://www.figma.com/file/IqhXWz3Iir7RMb5XH5gGfZ/?node-id=883%3A4006)\r\n\r\nU... | kotlin | Update terminology to Subscribers from Followers
Full Scope: https://github.com/Automattic/wordpress-mobile/issues/47
Design: [IqhXWz3Iir7RMb5XH5gGfZ-fi-883%3A4006](https://href.li/?https://www.figma.com/file/IqhXWz3Iir7RMb5XH5gGfZ/?node-id=883%3A4006)
Update terminology to Subscribers from Followers in all the app... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20769 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20690"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.PublicizeUseCaseTest" --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.FollowerTypesUseCaseTest" --tests "org.wordpress.android.ui.stats.refresh.lists.s... | diff --git a/WordPress/src/main/java/org/wordpress/android/models/PeopleListFilter.java b/WordPress/src/main/java/org/wordpress/android/models/PeopleListFilter.java
index 33213b8a937b..76daccbaf751 100644
--- a/WordPress/src/main/java/org/wordpress/android/models/PeopleListFilter.java
+++ b/WordPress/src/main/java/org/... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/FollowerTypesUseCaseTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/FollowerTypesUseCaseTest.kt
index 65a733f3f16d..8da714b91b26 100644
--- a/WordPress/s... | {
"org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.PublicizeUseCaseTest.trims services and adds view more link when hasMore is true": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.FollowersUseCaseTest.... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20763 | wordpress-mobile | WordPress-Android | 20,763 | closed | Remove social subscribers | Fixes #20714
This removes social subribers from the detail screen of the Total Followers card and additionally, changes the endpoint for the "Total Followers" card from `/sites/$site/stats/summary/` → `stats/subscribers`.
Additionally, this PR removes `FollowerTotalsUseCase`, which was already unused. This card... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "d7de297606e0cb8d6036c174353b49765dfc43d3"
} | [
{
"number": 20714,
"title": "Stats Insights: Remove social (publicize) subscribers",
"body": "Total Subscribers number on Insights is calculated by adding: wpcom + email + publicize (Jetpack social) subscribers. However, it's been removed from the web.\r\n\r\n1. Update Total Subscribers card on Insights... | kotlin | Stats Insights: Remove social (publicize) subscribers
Total Subscribers number on Insights is calculated by adding: wpcom + email + publicize (Jetpack social) subscribers. However, it's been removed from the web.
1. Update Total Subscribers card on Insights not to add publicize numbers
2. Update Total Subscribers -... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20763 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20714"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.lists.UiModelMapperTest" --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.FollowerTypesUseCaseTest" --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.Tota... | diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index 70f9185bdb38..27b1202ae4ba 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -2,6 +2,7 @@
24.9
-----
+* [*] [Jetpack-only] Removed Social section from the detail screen of Total Followers card [https://github.com/wordpress-mobile/WordPress-Android/pul... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/UiModelMapperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/UiModelMapperTest.kt
index 894c3855afd3..c04d853e861a 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/UiModelMap... | {
"org.wordpress.android.ui.stats.refresh.lists.UiModelMapperTest.mapInsights returns empty when there are only management blocks visible": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.lists.UiModelMapperTest.mapInsights returns success ui model when all th... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20756 | wordpress-mobile | WordPress-Android | 20,756 | closed | "stats/subscribers" deeplink | Fixes #20691
This makes `site` parameter optional in the stats deeplink and adds support for "jetpack://stats/subscribers" deeplink.
|deeplink|description|
|-|-|
|jetpack://stats|opens the latest tab from stats|
|jetpack://stats/insights|opens the INSIGHTS tab|
|jetpack://stats/day|opens the TRAFFIC tab and ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "6c79ab16dc342b470d0be18d904120db267682aa"
} | [
{
"number": 20691,
"title": "Deep link support",
"body": "Full Scope: https://github.com/Automattic/wordpress-mobile/issues/47\nDesign: [IqhXWz3Iir7RMb5XH5gGfZ-fi-883%3A4006](https://href.li/?https://www.figma.com/file/IqhXWz3Iir7RMb5XH5gGfZ/?node-id=883%3A4006)\n\n- Deep link to Subscribers tab\n- Deep... | kotlin | Deep link support
Full Scope: https://github.com/Automattic/wordpress-mobile/issues/47
Design: [IqhXWz3Iir7RMb5XH5gGfZ-fi-883%3A4006](https://href.li/?https://www.figma.com/file/IqhXWz3Iir7RMb5XH5gGfZ/?node-id=883%3A4006)
- Deep link to Subscribers tab
- Deep link to Traffic tab with appropriate granularity selected
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20756 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20691"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest" | diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index ca376cca8b49..70f9185bdb38 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -2,7 +2,7 @@
24.9
-----
-
+* [***] [Jetpack-only] Reorganized Stats to include updated Traffic and Insights tabs, along with a newly added Subscribers tab to improve subscrib... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/deeplinks/handlers/StatsLinkHandlerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/deeplinks/handlers/StatsLinkHandlerTest.kt
index 1c6984ff5c9d..35fa892d67c7 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/deeplinks/handlers/StatsLi... | {
"org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest.strips applink with all params": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest.opens stats screen for a site when timeframe not valid": {
"run": "PASS",
"te... | {
"org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest.opens stats screen from app link": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest.strips deeplink with all params": {
"run": "PASS",
"test": "FAIL",
"fix... | {
"org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest.strips deeplink without params": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.deeplinks.handlers.StatsLinkHandlerTest.does not handle stats URI with different host": {
"run": "PASS",
"test": "PAS... | {} |
wordpress-mobile__WordPress-Android-20750 | wordpress-mobile | WordPress-Android | 20,750 | closed | Fix: PublishSettingsViewModel NPE on create date | Fixes #18615
This PR adjusts `onAddToCalendar()` to handle scenarios where the `EditPostRepository.dateCreated` may be empty. Previously, the method would attempt to process the calendar event without considering the possibility of an empty dateCreated. This could potentially lead to null return from `DateTimeUtils... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "0b525f6e4925757f0a6b94849797684b5bf2d4a5"
} | [
{
"number": 18615,
"title": "NullPointerException: Attempt to invoke virtual method 'long java.util.Date.getTime()' on a null object reference",
"body": "Sentry Issue: [JETPACK-ANDROID-7TE](https://a8c.sentry.io/issues/4259423167/?referrer=github_integration)\n\n```\nNullPointerException: Attempt to inv... | kotlin | NullPointerException: Attempt to invoke virtual method 'long java.util.Date.getTime()' on a null object reference
Sentry Issue: [JETPACK-ANDROID-7TE](https://a8c.sentry.io/issues/4259423167/?referrer=github_integration)
```
NullPointerException: Attempt to invoke virtual method 'long java.util.Date.getTime()' on a nul... | This looks like it is coming from [an unannotated nullable in the Java utility code](https://github.com/wordpress-mobile/WordPress-Utils-Android/blob/20c490bdf3def25600c76b8cb9796eeccb14edc6/WordPressUtils/src/main/java/org/wordpress/android/util/DateTimeUtils.java#L63). If content loss is possible from this, it may be... | https://github.com/wordpress-mobile/WordPress-Android/pull/20750 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/18615"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PublishSettingsViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PublishSettingsViewModel.kt
index 0c3a87edcbef..d8672ec395f5 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/PublishSettingsViewModel.kt
+++ b/Word... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditPostPublishSettingsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/EditPostPublishSettingsViewModelTest.kt
index ecd6b449465b..3e6582489b32 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditPostPublis... | {
"org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest.updatePost updates post status from SCHEDULED to DRAFT when published date in past": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest.DISABLES notification when ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20729 | wordpress-mobile | WordPress-Android | 20,729 | closed | [Reader] Connect fetch tags logic with compose UI | Fixes #20624
https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/b5a79353-49f6-47b8-8366-5836f3388106
-----
## To Test:
- Install JP and sign in.
- Open "Reader".
- 🔍 Select "Tags" feed: loading, loaded, error and empty states should be displayed correctly ([actions not working yet](h... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "8955440ab42aad4cdbfba78a4349c54d059aac45"
} | [
{
"number": 20624,
"title": "[Reader] Implement horizontal posts list logic (loaded state)",
"body": "Depends on https://github.com/wordpress-mobile/WordPress-Android/issues/20623 and https://github.com/wordpress-mobile/WordPress-Android/issues/20588\n\nConnect fetched tags data to the list UI component... | kotlin | [Reader] Implement horizontal posts list logic (loaded state)
Depends on https://github.com/wordpress-mobile/WordPress-Android/issues/20623 and https://github.com/wordpress-mobile/WordPress-Android/issues/20588
Connect fetched tags data to the list UI component.
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20729 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20624"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" --tests "org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
index c4ce39ad344c..b54fdb83f60f 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
+++ b/WordPre... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt
index d4008189759b..3e55571fc74a 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmod... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.given valid tags, when fetchAll, then UI state should update properly": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest.Should map loaded Tag... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20684 | wordpress-mobile | WordPress-Android | 20,684 | closed | [Tags IA] Fetch posts for multiple tags | Fixes #20588
Move shared fetching logic to Repository and create ViewModel to use Repository to fetch posts for tags directly.
-----
## To Test:
- Open Jetpack
- Enable the `reader_tags_feed` feature flag in Debug Settings
- Go to Reader
- Select the `Tags` feed
- **Verify** a UI shows up that loads th... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "bbe122d406455ce714965776f3dffc6232d39dc5"
} | [
{
"number": 20588,
"title": "[Reader] Implement \"Tags\" feed fetching",
"body": "To populate the new _Tags_ feed we will need to fetch a few posts from each tags and create a map of tags -> post lists that can be used by the feed.\r\n\r\nSome important notes/ideas:\r\n* The fetching function/use-case c... | kotlin | [Reader] Implement "Tags" feed fetching
To populate the new _Tags_ feed we will need to fetch a few posts from each tags and create a map of tags -> post lists that can be used by the feed.
Some important notes/ideas:
* The fetching function/use-case could receive the list of tags to be fetched
* We will fetch a l... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20684 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20588"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.services.post.ReaderPostLogicFactoryTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" --tests "org.wordpress.android.ui.reader.sources.ReaderPostLocalSourceTest" --tests "org.wordpress.an... | diff --git a/WordPress/src/main/java/org/wordpress/android/datasets/wrappers/ReaderPostTableWrapper.kt b/WordPress/src/main/java/org/wordpress/android/datasets/wrappers/ReaderPostTableWrapper.kt
index eeabbd6a0e0f..8b532688a530 100644
--- a/WordPress/src/main/java/org/wordpress/android/datasets/wrappers/ReaderPostTable... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/BloggingPromptsPostTagProviderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/BloggingPromptsPostTagProviderTest.kt
index 73250ba0c7f5..5b1fc3546c74 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/blog... | {
"org.wordpress.android.ui.bloggingprompts.BloggingPromptsPostTagProviderTest.Should return the base Prompt ReaderTag when promptSearchReaderTag is called": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.sources.ReaderPostLocalSourceTest.given no changes and tag pr... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20608 | wordpress-mobile | WordPress-Android | 20,608 | closed | Stats: Add singular strings to weekly roundup notification | Fixes #17824
This fixes using the plural form of "view" and "comment" for singular values on Weekly roundup notifications.
Additionally, this fixes false positive test cases for
- `buildNotifications should not include likes and comments with 0 count`
- `buildNotifications should not include likes with 0 count`
... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "b24bac66ced3f1c5dea46561ef4e8849ae046a82"
} | [
{
"number": 17824,
"title": "Weekly Roundup: Add singular strings to notification",
"body": "### Expected behavior\r\nThe singular form of the noun is used when the value is 1.\r\n- view\r\n- like\r\n- comment\r\n\r\n### Actual behavior\r\nThe plural form of the noun is used when the value is 1.\r\n- vi... | kotlin | Weekly Roundup: Add singular strings to notification
### Expected behavior
The singular form of the noun is used when the value is 1.
- view
- like
- comment
### Actual behavior
The plural form of the noun is used when the value is 1.
- views
- likes
- comments
Observed in issue WPiOS issue: https://githu... |
<!--
1 failure: Please add a feat...
0 warning:
DangerID: danger-id-Peril;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Please add a feature label to this i... | https://github.com/wordpress-mobile/WordPress-Android/pull/20608 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/17824"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.workers.weeklyroundup.WeeklyRoundupNotifierTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/workers/weeklyroundup/WeeklyRoundupNotifier.kt b/WordPress/src/main/java/org/wordpress/android/workers/weeklyroundup/WeeklyRoundupNotifier.kt
index 93d7e89bf823..0e1643e929f9 100644
--- a/WordPress/src/main/java/org/wordpress/android/workers/weeklyroundup/Weekl... | diff --git a/WordPress/src/test/java/org/wordpress/android/workers/weeklyroundup/WeeklyRoundupNotifierTest.kt b/WordPress/src/test/java/org/wordpress/android/workers/weeklyroundup/WeeklyRoundupNotifierTest.kt
index 715b35f12b73..d174010e1cda 100644
--- a/WordPress/src/test/java/org/wordpress/android/workers/weeklyround... | {
"org.wordpress.android.workers.weeklyroundup.WeeklyRoundupNotifierTest.should show notification when the user is logged in and has sites": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.workers.weeklyroundup.WeeklyRoundupNotifierTest.buildNotifications should not have more ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20606 | wordpress-mobile | WordPress-Android | 20,606 | closed | [Bug] Fix root cause that caused StatsGranularTabsTest to fail. | Fixes #18065
There was a failing UI test that appeared flaky, `StatsGranularTabsTest`. Retrying appears to fix it. Every once in a while I also notice stats cards don't load properly. It's super hard to reproduce, even in UI tests.
At first I figured out part of the issue. I noticed each failing stats card would... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "2f077faf2b5ec3130bbe7caa0e5ea8b5797ec927"
} | [
{
"number": 18065,
"title": "Very first Stats card is not always loaded on screen",
"body": "### Expected behavior\r\n\r\nAll stats cards that can be shown on screen should be shown after opening the screen, no PTR should be required.\r\n\r\n### Actual behavior\r\n\r\n1. In some cases, for JP variant (I... | kotlin | Very first Stats card is not always loaded on screen
### Expected behavior
All stats cards that can be shown on screen should be shown after opening the screen, no PTR should be required.
### Actual behavior
1. In some cases, for JP variant (I could not reproduce this on WP), the very first Stats card is loade... | I could reproduce this using a real device by testing it on a high-traffic website. You can reproduce the issue on by testing it on mobile.blog.
I removed the "[Emulator]" label from the title.
<img src="https://github.com/wordpress-mobile/WordPress-Android/assets/2471769/ac9428e3-4a11-43da-952c-3ac6febc4c6b" widt... | https://github.com/wordpress-mobile/WordPress-Android/pull/20606 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/18065"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.AllTimeStatsUseCaseTest" --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.TodayStatsUseCaseTest" --tests "org.wordpress.android.ui.stats.refresh.lists.s... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/detail/PostDayViewsUseCase.kt b/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/detail/PostDayViewsUseCase.kt
index d6dd4e02c4d6..eb67940aaa83 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/stats/refres... | diff --git a/WordPress/src/androidTest/java/org/wordpress/android/e2e/StatsGranularTabsTest.kt b/WordPress/src/androidTest/java/org/wordpress/android/e2e/StatsGranularTabsTest.kt
index 89b11f852e76..ada96b9c90c6 100644
--- a/WordPress/src/androidTest/java/org/wordpress/android/e2e/StatsGranularTabsTest.kt
+++ b/WordPre... | {
"org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.FollowersUseCaseTest.maps empty followers to UI model": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.LatestPostSummaryUseCaseTest.returns Failed item... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20603 | wordpress-mobile | WordPress-Android | 20,603 | closed | Removes multiple calls to the WebSettings.getDefaultUserAgent api | Fixes #12259
## Description
This PR replaces multiple calls to the `WebSettings.getDefaultUserAgent`([which is not recommended](https://issuetracker.google.com/issues/289118199#comment9)) with just one, hoping to prevent the ANR of #12259 and probably reduce the crash count in #20147
The current implementation i... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "d1577bbdeb3a4d8a7cc780b4cb9d78ead2ad5688"
} | [
{
"number": 12259,
"title": "ApplicationNotResponding in UserAgent",
"body": "ANRs weren't available in Sentry until the last release, so this issue is not newly introduced. Please keep that in mind while debugging the issue so as not to limit it to the changes introduced recently.\r\n\r\n**Sentry Url**... | kotlin | ApplicationNotResponding in UserAgent
ANRs weren't available in Sentry until the last release, so this issue is not newly introduced. Please keep that in mind while debugging the issue so as not to limit it to the changes introduced recently.
**Sentry Url**: https://sentry.io/share/issue/09ee294fc5b3453bb0b2920117ae... | This issue has been marked as stale because:
* It has been inactive for the past year.
* It isn't in a project or a milestone.
* It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, or `good first issue`.
Please comment with an update if you believe this issue is still valid or if it can be closed. This issue wil... | https://github.com/wordpress-mobile/WordPress-Android/pull/20603 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/12259"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitemonitor.SiteMonitorUtilsTest" | diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index cca5a3431484..6676965acff1 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -2,7 +2,7 @@
24.7
-----
-
+* [*] [internal] Updates the way the app retrieves the User-Agent request header [https://github.com/wordpress-mobile/WordPress-Android/pull/20603]... | diff --git a/WordPress/src/androidTest/java/org/wordpress/android/UserAgentTest.java b/WordPress/src/androidTest/java/org/wordpress/android/UserAgentTest.java
index 8e93118c2d07..79ec7c5bec52 100644
--- a/WordPress/src/androidTest/java/org/wordpress/android/UserAgentTest.java
+++ b/WordPress/src/androidTest/java/org/wo... | {
"org.wordpress.android.ui.sitemonitor.SiteMonitorUtilsTest.when web server logs tab is launched, then event is tracked": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitemonitor.SiteMonitorUtilsTest.given url is null, when sanitize is requested, then url is empty": {
... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20596 | wordpress-mobile | WordPress-Android | 20,596 | closed | [Reader] Implement Tags IA feature flag | Fixes #20595
-----
## To Test:
- Install JP and sign in.
- Enable remote feature `reader_tags_feed`.
- Open "Reader".
- 🔍 Open the dropdown menu: "Tags" feed should be in the list.
- Disable remote feature `reader_tags_feed`.
- Restart the app.
- 🔍 Open "Reader" and dropdown menu: "Tags" feed should ... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "8b3a7b043d939febf2070195d03a358bdd128993"
} | [
{
"number": 20595,
"title": "[Reader] Implement feature flag for tags IA",
"body": "- Only display \"Tags\" feed item if the FF is enabled.\n- Only hide the \"Tags\" chip from \"Subscriptions\" feed if the FF is enabled."
}
] | kotlin | [Reader] Implement feature flag for tags IA
- Only display "Tags" feed item if the FF is enabled.
- Only hide the "Tags" chip from "Subscriptions" feed if the FF is enabled.
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20596 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20595"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest" --tests "org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index e3f33b5c6cf4..8b9c6ad61d76 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -150,6 +150,7 @@ android {
buildConfigField "boolean", "READER_DISCOVER_NEW_ENDPOINT", "false"
buildConfigField "boolean", "READER_READING_P... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelperTest.kt
index 0279f25bee2d..03e57616424e 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarM... | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN discover not present WHEN createMenu THEN discover menu item not created": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN saved not present WHEN createMe... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20586 | wordpress-mobile | WordPress-Android | 20,586 | closed | [Reader] Add "Tags" to dropdown menu | Fixes #20576
-----
## To Test:
- Install JP and sign in.
- Open "Reader".
- 🔍 Open the dropdown menu: there should be a "Tags" item with the correct icon (design: p1712144397494019/1712076563.723409-slack-C05N140C8H5)
<img width="198" alt="image" src="https://github.com/wordpress-mobile/WordPress-Android/... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "5220bd5a2a69349c744dfbfd603ca5913eef1d15"
} | [
{
"number": 20576,
"title": "[Reader] Add \"Tags\" item do dropdown menu",
"body": ""
}
] | kotlin | [Reader] Add "Tags" item do dropdown menu
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/20586 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20576"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/models/ReaderTag.java b/WordPress/src/main/java/org/wordpress/android/models/ReaderTag.java
index a8e8018e9814..dbd7b537e8cf 100644
--- a/WordPress/src/main/java/org/wordpress/android/models/ReaderTag.java
+++ b/WordPress/src/main/java/org/wordpress/android/mod... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewModelTest.kt
index 2f437f24465c..bc6e73735645 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewMo... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest.UiState is NOT updated with content state when loaded tags are empty": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest.Last selected tab is stored into shared preferences... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20564 | wordpress-mobile | WordPress-Android | 20,564 | closed | Change "∞" symbol with "100%" on stats | Fixes #17314
This changes "∞" symbol with "100%" on stats. The issue description states removing "∞" symbol but this PR changes it to "%100" and matches this behavior with the web.
|before|after|
|-|-|
|<img src="https://github.com/wordpress-mobile/WordPress-Android/assets/2471769/08158f05-6293-49a5-b1f5-25b1... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "c188122e6ee1d4b1fe844dc127ef1bfd780a3801"
} | [
{
"number": 17314,
"title": "\"(∞)\" shouldn't be used for infinite percentages in stats screens",
"body": "### Expected behavior\r\nWhen the percentage is `∞` for data in stats screens, we should only show the increase.\r\n<img width=\"353\" alt=\"expected\" src=\"https://user-images.githubusercontent.... | kotlin | "(∞)" shouldn't be used for infinite percentages in stats screens
### Expected behavior
When the percentage is `∞` for data in stats screens, we should only show the increase.
<img width="353" alt="expected" src="https://user-images.githubusercontent.com/2471769/195326228-118c274d-cb89-4806-a9a1-2f1a2987dfea.png">
... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20564 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/17314"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.utils.StatsUtilsTest" | diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index 47aded33e692..7cb01b15dcad 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -4,6 +4,7 @@
-----
* [**] Block editor: Highlight text fixes [https://github.com/WordPress/gutenberg/pull/57650]
* [*] Block editor: Fixes an Aztec editor crash occurring on s... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/StatsUtilsTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/StatsUtilsTest.kt
index 4367ff9d59ea..c875d6565ecc 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/StatsUtilsTest.k... | {
"org.wordpress.android.ui.stats.refresh.utils.StatsUtilsTest.test stats long formatter": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.utils.StatsUtilsTest.returns null value when input is null integer and default is empty": {
"run": "PASS",
"test"... | {
"org.wordpress.android.ui.stats.refresh.utils.StatsUtilsTest.when buildChange, should call PercentFormatter": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.wordpress.android.ui.stats.refresh.utils.StatsUtilsTest.returns default value when input is null long and default is not empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.utils.StatsUtilsTest.build change with negative difference": {
"run": "P... | {} |
wordpress-mobile__WordPress-Android-20526 | wordpress-mobile | WordPress-Android | 20,526 | closed | Fix open traffic tab from today's stats card | Fixes #20487
This updates Today's Stats card to have it open "By day" granularity.
-----
## To Test:
<!-- Test instructions per dependency update: https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/docs/test_instructions_per_dependency_update.md -->
Test this with both the `stats_traffic_ta... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "93d9440fb1e53ca28ea3e94f84320b0633c27c65"
} | [
{
"number": 20487,
"title": "Today's Stats card should open the day granularity on stats",
"body": "### Expected behavior\r\nToday's Stats card should open the TRAFFIC tab with \"By day\" granularity or DAYS tab (when the `stats_traffic_tab` flag is off).\r\n\r\n### Actual behavior\r\nToday's Stats card... | kotlin | Today's Stats card should open the day granularity on stats
### Expected behavior
Today's Stats card should open the TRAFFIC tab with "By day" granularity or DAYS tab (when the `stats_traffic_tab` flag is off).
### Actual behavior
Today's Stats card is opening the INSIGHTS tab.
[todays stats issue.webm](https:/... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20526 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20487"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dashboard.todaysstats.TodaysStatsViewModelSliceTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteFragment.kt
index 6f8c47d8c624..da8880893f82 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteFragment.kt
+++ b/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/todaysstats/TodaysStatsViewModelSliceTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/todaysstats/TodaysStatsViewModelSliceTest.kt
index 417d24ae3ef3..44cbebff3a7b 100644
--- a/WordPress/src/test/java/o... | {
"org.wordpress.android.ui.mysite.cards.dashboard.todaysstats.TodaysStatsViewModelSliceTest.given todays stats card, when more menu is accessed, then event is tracked": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dashboard.todaysstats.TodaysStatsViewModelS... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20513 | wordpress-mobile | WordPress-Android | 20,513 | closed | [Reader] Use `"follow"` for tag strings instead of `"subscribe"` | Fixes #20297
-----
## To Test:
1. Launch Jetpack and login
2. Do a general smoke test of Reader screens
3. All tag related strings should be using `"follow"` instead of `"subscribe"`
-----
## Regression Notes
1. Potential unintended areas of impact
- None
2. What I did to test those areas o... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "1f319a4a6ba66658831ab46a19cf040508188b0a"
} | [
{
"number": 20297,
"title": "[Reader] Use \"follow\" for tags",
"body": "We recently changed several Strings in the apps from \"follow\"/\"followed\"/\"following\" to \"subscribe\"/\"subscribed\"/\"subscriptions\", but it turns out these new terms should be only used for **blogs**, so we now need to rev... | kotlin | [Reader] Use "follow" for tags
We recently changed several Strings in the apps from "follow"/"followed"/"following" to "subscribe"/"subscribed"/"subscriptions", but it turns out these new terms should be only used for **blogs**, so we now need to revert some of those changes back to the "follow" when talking about **ta... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20513 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20297"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.viewmodel.reader.SubfilterPageViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderSubsActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderSubsActivity.java
index 2bf6b1cb6b59..e572199e46f8 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderSubsActivity.java
+++ b/WordPress/src... | diff --git a/WordPress/src/test/java/org/wordpress/android/viewmodel/reader/SubfilterPageViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/viewmodel/reader/SubfilterPageViewModelTest.kt
index 871fc4ce166a..0eb45f29abdc 100644
--- a/WordPress/src/test/java/org/wordpress/android/viewmodel/reader/SubfilterP... | {
"org.wordpress.android.viewmodel.reader.SubfilterPageViewModelTest.onSubFiltersChanged shows empty view for WPCOM tags when requested": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.viewmodel.reader.SubfilterPageViewModelTest.onSubFiltersChanged shows empty view for self-h... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20480 | wordpress-mobile | WordPress-Android | 20,480 | closed | Redirects to the site creation failure flow when the endpoint fails | Fixes #20479
## Description
Redirects to the site creation failure flow when the endpoint fails instead of an unhandled crash
-----
## To Test:
Since I was not able to reproduce this issue I would recommend a sanity check of the site creation flow
-----
## Regression Notes
1. Potential unintended ar... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "3e2363d0223dd2b1feb74308e8cb433de4611af3"
} | [
{
"number": 20479,
"title": "IllegalStateException: Site already exists - seems like an issue with domain suggestions endpoint",
"body": "Sentry Issue: [JETPACK-ANDROID-DZ0](https://a8c.sentry.io/issues/4584356763/?referrer=github_integration)\n\n```\nIllegalStateException: Site already exists - seems l... | kotlin | IllegalStateException: Site already exists - seems like an issue with domain suggestions endpoint
Sentry Issue: [JETPACK-ANDROID-DZ0](https://a8c.sentry.io/issues/4584356763/?referrer=github_integration)
```
IllegalStateException: Site already exists - seems like an issue with domain suggestions endpoint
at org.wo... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
Sentry Issue: [JETPACK-ANDROID-1RW](https://a8c.sentry.io/issues/3857462344/?referrer=github_integration)
Checking the sentry logs all of them contain the following error:
```
e/WordPress-SITE_CREATION: Site already exists - seems like an issue with domain ... | https://github.com/wordpress-mobile/WordPress-Android/pull/20480 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20479"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitecreation.services.SiteCreationServiceManagerTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/services/SiteCreationServiceManager.kt b/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/services/SiteCreationServiceManager.kt
index 86a62720f401..b4dc3824e639 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/sitecrea... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/services/SiteCreationServiceManagerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/services/SiteCreationServiceManagerTest.kt
index a70333b10838..ed8ecd68a3a2 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/... | {} | {
"org.wordpress.android.ui.sitecreation.services.SiteCreationServiceManagerTest.verifyFailureFlowWhenTheSiteExistsAndIsNotARetry": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.wordpress.android.ui.sitecreation.services.SiteCreationServiceManagerTest.verifyDispatcherRegistrationHandledCorrectly": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.sitecreation.services.SiteCreationServiceManagerTest.verifyServiceStateIsBeingUpdated": {
"run... | {} |
wordpress-mobile__WordPress-Android-20477 | wordpress-mobile | WordPress-Android | 20,477 | closed | [Reader] Fix `Reader` showing posts from a language different than the selected one | Fixes #19969
-----
There are many testing steps, but basically the goal of this PR is to make sure the content shown in the Reader matches the app selected language. If you see any `Reader` content using the wrong language, please let me know.
## To Test:
1. Install Jetpack and sign in.
2. Open "Me" scree... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "22edd927e6afec7bd13a82952e7ef2a3e1ac387c"
} | [
{
"number": 19969,
"title": "[Reader][Bug] Locale not working properly on some Reader requests",
"body": "### Expected behavior\r\nAn appropriate locale-related parameter should be sent on Reader requests, based on the current language of the System/App to provide relevant results and content to the use... | kotlin | [Reader][Bug] Locale not working properly on some Reader requests
### Expected behavior
An appropriate locale-related parameter should be sent on Reader requests, based on the current language of the System/App to provide relevant results and content to the user.
### Actual behavior
Several Reader screens/requests... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20477 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19969"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.models.recommend.RecommendApiCallsProviderTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/models/ReaderPost.java b/WordPress/src/main/java/org/wordpress/android/models/ReaderPost.java
index cbe82cda4cf3..8f8f10a92f5d 100644
--- a/WordPress/src/main/java/org/wordpress/android/models/ReaderPost.java
+++ b/WordPress/src/main/java/org/wordpress/android/... | diff --git a/WordPress/src/test/java/org/wordpress/android/models/recommend/RecommendApiCallsProviderTest.kt b/WordPress/src/test/java/org/wordpress/android/models/recommend/RecommendApiCallsProviderTest.kt
index 9132c83d0598..ddf347895251 100644
--- a/WordPress/src/test/java/org/wordpress/android/models/recommend/Reco... | {
"org.wordpress.android.models.recommend.RecommendApiCallsProviderTest.error is tracked on wrong app name": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.models.recommend.RecommendApiCallsProviderTest.error is tracked on parse error": {
"run": "PASS",
"test": "NONE"... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20216 | wordpress-mobile | WordPress-Android | 20,216 | closed | [Reader][0 blogs/0 tags] Fix Subscription feed infinite loading and fetch when tapping filters | Fixes #20009
Fixes #20010
The biggest change in this PR is fixing the logic inside `ReaderUpdateLogic` to avoid unnecessary DB writes which were happening always, even when the server tag list was the same as the local tag list, which in turn made the `FollowTagsChanged` stop being triggered every single time a f... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "40ece18c60f4a1493f54a7f331b00efdcb4b1979"
} | [
{
"number": 20010,
"title": "[Reader IA][Bug][0 tags/blogs] Infinite loading indicator on Subscription feed after subscribing to tags",
"body": "### Expected behavior\r\nAfter going to \"Suggested tags\" flow inside the Tag filter bottom and returning to the Subscriptions feed it should still show the e... | kotlin | [Reader IA][Bug][0 tags/blogs] Infinite loading indicator on Subscription feed after subscribing to tags
### Expected behavior
After going to "Suggested tags" flow inside the Tag filter bottom and returning to the Subscriptions feed it should still show the empty state (as there are still 0 blogs being followed) and n... | https://github.com/wordpress-mobile/WordPress-Android/pull/20216 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20010",
"https://github.com/wordpress-mobile/WordPress-Android/issues/20009"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.repository.ReaderDiscoverDataProviderTest" --tests "org.wordpress.android.ui.reader.repository.FetchFollowedTagsUseCaseTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/datasets/ReaderTagTable.java b/WordPress/src/main/java/org/wordpress/android/datasets/ReaderTagTable.java
index 977f7eaf0f2e..7c7530756b12 100644
--- a/WordPress/src/main/java/org/wordpress/android/datasets/ReaderTagTable.java
+++ b/WordPress/src/main/java/org/... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/repository/FetchFollowedTagsUseCaseTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/repository/FetchFollowedTagsUseCaseTest.kt
index a581bc43584f..5c0c086000e0 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/repos... | {
"org.wordpress.android.ui.reader.repository.ReaderDiscoverDataProviderTest.when loadData with existsInMemory data posted to discover feed": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.repository.ReaderDiscoverDataProviderTest.when loadData with forceReload true... | {} | {} | {} | |
wordpress-mobile__WordPress-Android-20186 | wordpress-mobile | WordPress-Android | 20,186 | closed | 🤖 Bring the user straight to the comments reader view | Fixes #20096
-----
## Description
This PR navigates non-admin users that cannot moderate a comment directly to the comments reader view
## To Test:
### A. Non-admin user
1. Create a post with an authorised user and add some comments
2. Log in with another user in the Jetpack app that does not administer th... | {
"label": "wordpress-mobile:feature/notifications_refresh_p1",
"ref": "feature/notifications_refresh_p1",
"sha": "fdd373bbf2ddb4f47375baf0de3558950940d0df"
} | [
{
"number": 20096,
"title": "🤖 Bring the user straight to the comments reader view",
"body": "Non-admin users that cannot moderate comment should skip the comment details screen and be directed straight to the comments reader view"
}
] | kotlin | 🤖 Bring the user straight to the comments reader view
Non-admin users that cannot moderate comment should skip the comment details screen and be directed straight to the comments reader view
|
<!--
2 failure: Please add a type..., Please add a feat...
0 warning:
DangerID: danger-id-Peril;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>
Please add... | https://github.com/wordpress-mobile/WordPress-Android/pull/20186 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20096"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.notifications.NotificationsListViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java
index 6d67608adebb..3d432ded823f 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java
+++ b/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/notifications/NotificationsListViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/notifications/NotificationsListViewModelTest.kt
new file mode 100644
index 000000000000..ff44cca7c117
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress... | {
"org.wordpress.android.ui.notifications.NotificationsListViewModelTest.WHEN the note is not a comment THEN open detail view": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.notifications.NotificationsListViewModelTest.WHEN the note cannot be retrieved THEN try opening th... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20153 | wordpress-mobile | WordPress-Android | 20,153 | closed | 🤖 Add the content of a comment in the push notification | Fixes #20099
## Description
This PR adds the whole content of a comment type push notification (as it is passed by the service).
It also changes the comment notification title aligning with iOS.
|Before Android|Current iOS|
|---|---|
|<img width="320" src="https://github.com/wordpress-mobile/WordPress-Android... | {
"label": "wordpress-mobile:feature/notifications_refresh_p1",
"ref": "feature/notifications_refresh_p1",
"sha": "cf22b77d177087410131b47104d46108bc9da0ef"
} | [
{
"number": 20099,
"title": "🤖 Add the content of a comment in the push notification",
"body": "The push notification should include the content of the comment (like, comment). When the content does not fit [the notification should expand](https://developer.android.com/develop/ui/views/notifications#ex... | kotlin | 🤖 Add the content of a comment in the push notification
The push notification should include the content of the comment (like, comment). When the content does not fit [the notification should expand](https://developer.android.com/develop/ui/views/notifications#expandable).
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/20153 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20099"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.push.NotificationHelperTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/push/GCMMessageHandler.java b/WordPress/src/main/java/org/wordpress/android/push/GCMMessageHandler.java
index 5495ae79f441..1ecc1ad4ff77 100644
--- a/WordPress/src/main/java/org/wordpress/android/push/GCMMessageHandler.java
+++ b/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/push/NotificationHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/push/NotificationHelperTest.kt
new file mode 100644
index 000000000000..77430434c066
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress/android/push/NotificationHelperTest.kt
... | {
"org.wordpress.android.push.NotificationHelperTest.WHEN a PN that is a comment has a comment payload THEN the comment is used as a message": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.push.NotificationHelperTest.WHEN a PN that is not a comment contains a message argumen... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20130 | wordpress-mobile | WordPress-Android | 20,130 | closed | [Reader IA] Simplify Reader Quick Start flow for new UX | Fixes #20109
- Remove unused code relative to the old top app bar and menu
- Update the Quick Start flow to auto-complete upon showing Snackbar message
- Update snackbar message for WP.com users to mention Subscriptions feed instead of Settings
- No longer try to go to Discover feed when doing the quick start fl... | {
"label": "wordpress-mobile:release/24.2",
"ref": "release/24.2",
"sha": "dc9d7c1c5221088e62fb26cd31d457dad04a4560"
} | [
{
"number": 20109,
"title": "[Reader IA][Bug] Inconsistent reader UI state under circumstances going over quickstart",
"body": "Internal ref: p1706830673644549?thread_ts=1706821601.141289&cid=C01CW1VMLAF-slack-C01CW1VMLAF\r\n\r\n### Expected behavior\r\nWhen Subscriptions is selected and we go into the ... | kotlin | [Reader IA][Bug] Inconsistent reader UI state under circumstances going over quickstart
Internal ref: p1706830673644549?thread_ts=1706821601.141289&cid=C01CW1VMLAF-slack-C01CW1VMLAF
### Expected behavior
When Subscriptions is selected and we go into the reader quickstart step, the Discover feed is autoselected by t... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20130 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20109"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.discover.interests.ReaderInterestsViewModelTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/quickstart/QuickStartMySitePrompts.kt b/WordPress/src/main/java/org/wordpress/android/ui/quickstart/QuickStartMySitePrompts.kt
index 5861be66f0f4..4d200bdbfb34 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/quickstart/QuickStartMySitePrompts.k... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/interests/ReaderInterestsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/interests/ReaderInterestsViewModelTest.kt
index 1943a6a2f15a..d098e17f6477 100644
--- a/WordPress/src/test/java/org/wordpress/android... | {
"org.wordpress.android.ui.reader.discover.interests.ReaderInterestsViewModelTest.interest selected if onInterestAtIndexToggled invoked on a deselected interest": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.interests.ReaderInterestsViewModelTest.snackba... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20090 | wordpress-mobile | WordPress-Android | 20,090 | closed | [Reader IA] Fix Discover scrolling to top when loading more posts | Fixes #19968
This prevents the stale information of this field from being kept in the `uiState` and being consumed by the UI incorrectly multiple times. An event makes more sense here since we want the action to happen once at a very specific moment, only that event is triggered.
### Demo
_Note: the first flow ... | {
"label": "wordpress-mobile:feature/reader-ia",
"ref": "feature/reader-ia",
"sha": "92df6716814466e7669d68b40ce05b4ccbe12cd0"
} | [
{
"number": 19968,
"title": "[Reader][Bug] Discover scrolls to top when loading more posts",
"body": "### Expected behavior\r\nWhen scrolling down the Discover feed to load older posts, after doing a pull to refresh, the screen should not scroll back to the top.\r\n\r\n### Actual behavior\r\nWhen scroll... | kotlin | [Reader][Bug] Discover scrolls to top when loading more posts
### Expected behavior
When scrolling down the Discover feed to load older posts, after doing a pull to refresh, the screen should not scroll back to the top.
### Actual behavior
When scrolling down the Discover feed to load older posts, **after doing a ... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20090 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19968"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverFragment.kt
index bea9580b298a..00918013c71e 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscov... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt
index d3d7227e6465..1db7219634ec 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/Re... | {
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.When user picks a site for reblog action the app shows the editor": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.if ReaderRecommendedBlogsCard exist then R... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20077 | wordpress-mobile | WordPress-Android | 20,077 | closed | Fixes: site monitor prevent webview reload | ## Fixes
#20067
## Description
This PR fixes the issue of reloading of the webviews in site monitoring activity when the tabs are selected again.
[Screen_recording_20240131_151636.webm](https://github.com/wordpress-mobile/WordPress-Android/assets/17463767/7b014247-4a46-41c7-b5de-d856f718e494)
## Pendin... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "8ec6d7eac86c05b3f4abcc2835db6d862adf4275"
} | [
{
"number": 20067,
"title": "Site Monitor: Prevent webview reload",
"body": "Prevent the webview from reloading when navigating between tabs"
}
] | kotlin | Site Monitor: Prevent webview reload
Prevent the webview from reloading when navigating between tabs
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/20077 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20067"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitemonitor.SiteMonitorUtilsTest" --tests "org.wordpress.android.ui.sitemonitor.SiteMonitorWebViewClientTest" --tests "org.wordpress.android.ui.sitemonitor.SiteMonitorParentViewModelTest" --tests "org.wordpress.android.ui.sitemonit... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/personalization/PersonalizationActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/personalization/PersonalizationActivity.kt
index 94e60930694d..ac9ab5de738d 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/perso... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/sitemonitor/SiteMonitorMapperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/sitemonitor/SiteMonitorMapperTest.kt
new file mode 100644
index 000000000000..d9b349bc2873
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress/android/ui/sitemonito... | {
"org.wordpress.android.ui.sitemonitor.SiteMonitorTabViewModelSliceTest.given preparing state, when url is loaded, then uiState loaded is not posted": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitemonitor.SiteMonitorWebViewClientTest.when onPageFinished, then should ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19996 | wordpress-mobile | WordPress-Android | 19,996 | closed | [Reader IA] Update Reader strings | Fixes #19961
Update Reader strings to new terminologies:
- `Site` -> `Blog`
- `Follow` -> `Subscribe`
- `Topic` -> `Tag`
-----
## To Test:
- Launch Jetpack and login
- Do a general smoke test of Reader screens
- Look for any of the following strings:
- Follow, follows, unfollow, following, etc
... | {
"label": "wordpress-mobile:feature/reader-ia",
"ref": "feature/reader-ia",
"sha": "e01610c0eaaccf7a8b20976ca58a628ee6efcce8"
} | [
{
"number": 19961,
"title": "[Reader IA] Update all “Follow” and “Following” terms to “Subscribe” and “Subscribed”",
"body": "Context: p1703152769063979-slack-C05N140C8H5"
}
] | kotlin | [Reader IA] Update all “Follow” and “Following” terms to “Subscribe” and “Subscribed”
Context: p1703152769063979-slack-C05N140C8H5
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19996 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19961"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.discover.ReaderPostMoreButtonUiStateBuilderTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderBlogFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderBlogFragment.java
index 696b3e44118f..bba413b96c1f 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderBlogFragment.java
+++ b/WordPress/src... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderPostMoreButtonUiStateBuilderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderPostMoreButtonUiStateBuilderTest.kt
index f95a2b56e003..aadbb434364c 100644
--- a/WordPress/src/test/java/org/wordpress/android... | {
"org.wordpress.android.ui.reader.discover.ReaderPostMoreButtonUiStateBuilderTest.does not contain bookmark action when includeBookmark is false": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.ReaderPostMoreButtonUiStateBuilderTest.contains unfollow actio... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19940 | wordpress-mobile | WordPress-Android | 19,940 | closed | Format the value on the total followers card | Fixes #19893
This adds a feature to format the Total Followers card by
- using comma for values greater than 999,
- using suffixes ("M", "B" etc.) for values equal to or exceeding 1M.
The Total Followers card's behavior is now the same as other total cards.
|before|after|after|
|-|-|-|
|<img src="https://g... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "d0b14ceb14d8e22cc544a631ad90de416a16d5e6"
} | [
{
"number": 19893,
"title": "Use thousands separator on Total Followers card",
"body": "### Expected behavior\r\n\r\nTotal Followers count should use the same thousand formatting as other numbers in Stats. \r\n\r\n### Actual behavior\r\n\r\n<img src=\"https://github.com/wordpress-mobile/WordPress-Androi... | kotlin | Use thousands separator on Total Followers card
### Expected behavior
Total Followers count should use the same thousand formatting as other numbers in Stats.
### Actual behavior
<img src="https://github.com/wordpress-mobile/WordPress-Android/assets/1898325/3cf32cdf-9e44-4147-8979-74351ec90470" width="350" />... | 👋 @irfano, @ravishanker, is this something either of you could y'all could fix this week? It's part of a call (p1704733151989019/1704732905.227079-slack-C0436E5L5V1) to fix missing thousand separators in the app, so if you see any others let's fix them.
It's worth considering if the string should be abbreviated e.g. 1... | https://github.com/wordpress-mobile/WordPress-Android/pull/19940 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19893"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.TotalFollowersUseCaseTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/TotalFollowersUseCase.kt b/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/TotalFollowersUseCase.kt
index 65cddd723572..28deb93cc99c 100644
--- a/WordPress/src/mai... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/TotalFollowersUseCaseTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/TotalFollowersUseCaseTest.kt
index 1c01e9fc18af..93165d577ace 100644
--- a/WordPress... | {
"org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.TotalFollowersUseCaseTest.maps error item to UI model": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.lists.sections.insights.usecases.TotalFollowersUseCaseTest.maps summary to UI mod... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19860 | wordpress-mobile | WordPress-Android | 19,860 | closed | [Reader IA] Open subscription management from Filter sheet | Fixes #19859
> [!CAUTION]
> Should not be merged before #19856
Adds the `Edit` button to the Filter bottom sheet and opens the existing "Subscription Management" screen when tapping that button.
>[!Important]
> In the Reader IA project we are using the word "tag" instead of "topic" and "blog" instead of "si... | {
"label": "wordpress-mobile:feature/reader-ia",
"ref": "feature/reader-ia",
"sha": "9ee4b4fe3246331c3971d12bd21f48d924cfcccd"
} | [
{
"number": 19859,
"title": "[Reader IA] Open existing subscription management screen from Filter sheets",
"body": "Initially, both for the Blogs and Tags Filter sheet, we will add an \"Edit\" button on the top right, which should simply open the existing subscription management screen, the same way as ... | kotlin | [Reader IA] Open existing subscription management screen from Filter sheets
Initially, both for the Blogs and Tags Filter sheet, we will add an "Edit" button on the top right, which should simply open the existing subscription management screen, the same way as the previous "Manage Subscription" top app bar button did.... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19860 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19859"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.subfilter.SubFilterViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java
index b0c2e994c1fc..9836f0d2a617 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java
+++ b/W... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/subfilter/SubFilterViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/subfilter/SubFilterViewModelTest.kt
index 5b03a80bee56..9e3565518c74 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/subfilter/SubFilter... | {
"org.wordpress.android.ui.reader.subfilter.SubFilterViewModelTest.onSubfilterSelected set expected readerModeInfo when a site filter was tapped": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.subfilter.SubFilterViewModelTest.when user id changed a tags and blogs ... | {} | {} | {} |
wordpress-mobile__WordPress-Android-21707 | wordpress-mobile | WordPress-Android | 21,707 | closed | Reader Discover not matching iOS & Web | Fixes #21706
The "Discover" stream in the Android reader shows different content than the iOS and web readers. There were two primary reasons for this:
* The Discover stream showed an empty view when the user wasn't following any tags
* We should request the `dailyprompt` and `wordpress` tags to match the other ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "dbf22f7b04c934a14b56507799a783cb76c0d620"
} | [
{
"number": 21706,
"title": "Issues with Reader Discover not matching iOS & Web",
"body": "There are a couple of issues preventing the Android Reader's \"Discover\" view from matching the iOS and web readers.\n\n* When there are no followed tags we should request the `dailyprompt` and `wordpress` tags.\... | kotlin | Issues with Reader Discover not matching iOS & Web
There are a couple of issues preventing the Android Reader's "Discover" view from matching the iOS and web readers.
* When there are no followed tags we should request the `dailyprompt` and `wordpress` tags.
* If you're not following any tags and try to view Discover,... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/21707 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/21706"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModel.kt
index 4fb2ccc2417b..559cce8a0a8a 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDisc... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt
index c1fc2ec37b46..176629483ccc 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/Re... | {
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.Scroll to top is triggered when discover feed is updated after swipe to refresh": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.When user clicks on more but... | {} | {} | {} |
wordpress-mobile__WordPress-Android-21466 | wordpress-mobile | WordPress-Android | 21,466 | closed | Removed feedback link from reading preferences | Fixes #21465
This PR removes the feedback link from the Reading Preferences screen. To test, simply go to Reading Preferences and verify this link no longer appears:
| {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "24699b0a33ff3b2877263dd372b4886942b5bb0a"
} | [
{
"number": 21465,
"title": "Remove feedback link from reading preferences",
"body": "This feedback link has been removed from reading preferences on iOS. We should do the same on Android.\r\n\r\n\r\n"
}
] | kotlin | Remove feedback link from reading preferences
This feedback link has been removed from reading preferences on iOS. We should do the same on Android.
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/21466 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/21465"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderReadingPreferencesViewModelTest" --tests "org.wordpress.android.ui.reader.tracker.ReaderReadingPreferencesTrackerTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderReadingPreferencesDialogFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderReadingPreferencesDialogFragment.kt
index 6c94e888d2e0..56918efa5174 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderR... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/tracker/ReaderReadingPreferencesTrackerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/tracker/ReaderReadingPreferencesTrackerTest.kt
index 9a7593a8a5ed..59dd78e283e4 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/read... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderReadingPreferencesViewModelTest.when onScreenClosed is called with original preferences then it doesn't emit UpdatePostDetail": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderReadingPreferencesView... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20947 | wordpress-mobile | WordPress-Android | 20,947 | closed | [Reader] Remove improvements FF and unused UI files | Fixes #19261
-----
## To Test:
Basically the Reader should continue to work as expected, including all the feeds (`Discover`, `Subscriptions`, `Saved`, `Liked`, `Your Tags` and custom lists), post details, recommendation cards on `Discover`, actions, etc.
It would be nice to also test it out using light and ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "5f0bc7d19880ac26bdb5402b08d40b563c7de29a"
} | [
{
"number": 19261,
"title": "[Reader Improvements] Remove all the Reader files from the previous layout",
"body": "For the `Reader Improvements` feature we've been duplicating many files to simplify keeping the changes behind a feature flag. The new files usually have a `_new` suffix. After the feature ... | kotlin | [Reader Improvements] Remove all the Reader files from the previous layout
For the `Reader Improvements` feature we've been duplicating many files to simplify keeping the changes behind a feature flag. The new files usually have a `_new` suffix. After the feature is live and 🟢 , we should remove the `Reader Improvemen... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20947 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19261"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest" --tests "org.wordpress.android.ui.reader.discover.ReaderPostUiStateBuilderTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index fd7eb641d383..bca68ced51e8 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -190,7 +190,6 @@ android {
buildConfigField "boolean", "CONTACT_SUPPORT_CHATBOT", "false"
buildConfigField "boolean", "ENABLE_DOMAIN_MANAGEM... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt
index 06995bd7a6b1..c1fc2ec37b46 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/Re... | {
"org.wordpress.android.ui.reader.discover.ReaderPostUiStateBuilderTest.Comments button is disabled when the user is logged off and the post does not have any comments for new UI": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.ReaderPostUiStateBuilderTest... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20940 | wordpress-mobile | WordPress-Android | 20,940 | closed | [Reader] Show custom lists directly if there are 2 or fewer items | Fixes #20033
-----
## To Test:
- Make sure you have more than 2 custom reading lists (you can see your lists [here](https://wordpress.com/read)).
- Install JP and sign in.
- Open Reader.
- 🔍 Expand the dropdown menu: you should see the "Lists" submenu item, and when tapping on it you should see the names of... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "a24e5d1d040b312f72243ec291ae56f2b44f8cce"
} | [
{
"number": 20033,
"title": "[Reader IA] Show lists directly on dropdown menu if there are 2 or fewer",
"body": "We are currently grouping the Lists in a \"Lists\" submenu independent of the number of lists the user has, but we should only show that submenu when the user has over 2 lists.\r\n\r\nSo if t... | kotlin | [Reader IA] Show lists directly on dropdown menu if there are 2 or fewer
We are currently grouping the Lists in a "Lists" submenu independent of the number of lists the user has, but we should only show that submenu when the user has over 2 lists.
So if the user has 2 or fewer, they should be displayed directly in t... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20940 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20033"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelper.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelper.kt
index ba94c014f5c5..e5b979bd9bc3 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelpe... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelperTest.kt
index 03e57616424e..e9850dab73b1 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarM... | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN custom lists has 2 items or less WHEN createMenu THEN custom lists items are shown outside a submenu": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN all... | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN a8c not present WHEN createMenu THEN a8c menu item not created": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN single menu item built with helper WHEN getReaderTagIndexFromMenuItem then return correct index": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN liked no... | {} |
wordpress-mobile__WordPress-Android-20939 | wordpress-mobile | WordPress-Android | 20,939 | closed | Post List: Fix excessive media requests | Fixes #20905
This PR fixes the excessive calls to fetch media when loading the post list by introducing and managing ongoing fetch requests in `PostListFeaturedImageTracker`. These changes aim to prevent redundant fetch requests.
Changes include
- In `PostListFeaturedImageTracker` Introduced `ongoingRequests`, ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "fa38edf99cd4d7739f9a8bdaa2154c8ec7cb3047"
} | [
{
"number": 20905,
"title": "Excessive Media Requests Delay Critical Post Operations",
"body": "### Expected behavior\r\n- The app only generates one request to the media endpoint for each featured image of the posts to be fetched.\r\n- Post management operations aren't locked due to fetching featured i... | kotlin | Excessive Media Requests Delay Critical Post Operations
### Expected behavior
- The app only generates one request to the media endpoint for each featured image of the posts to be fetched.
- Post management operations aren't locked due to fetching featured images of posts.
### Actual behavior
When opening the app... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
After investigating the issue, I noticed the following:
- The request to the media endpoint is related to the featured image of posts shown in the post list ([reference](https://github.com/wordpress-mobile/WordPress-Android/blob/f8db3db3ee1f2ce13c8da6344aa... | https://github.com/wordpress-mobile/WordPress-Android/pull/20939 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20905"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.PostListFeaturedImageTrackerTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListEventListener.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListEventListener.kt
index 16d7e3067a53..85e775d67c66 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListEventListener.kt
+++ b/WordPress/src... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/PostListFeaturedImageTrackerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/PostListFeaturedImageTrackerTest.kt
new file mode 100644
index 000000000000..a9616c3fd5b1
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress/android/ui/... | {
"org.wordpress.android.ui.posts.PostListFeaturedImageTrackerTest.given id not in map or store, when invoked, then return null and dispatch fetch request": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.PostListFeaturedImageTrackerTest.given id exists in map, when g... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20791 | wordpress-mobile | WordPress-Android | 20,791 | closed | [Tags Feed] Implement pull-to-refresh | Fixes #20707
Add pull-to-refresh to Tags Feed, which reloads the user's sites and tags then "restarts" the Tags Feed, fetching newer posts for each of the tags.
This also fixes the wrong post image being shown (it was showing the site avatar instead of the featured image).
-----
## To Test:
1. Open Jetp... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "2aa1835e2591324e65883df21cd394da540615ea"
} | [
{
"number": 20707,
"title": "[Reader] Implement pull-to-refresh in \"Tags\" feed",
"body": null
}
] | kotlin | [Reader] Implement pull-to-refresh in "Tags" feed
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20791 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20707"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
index 5dea6134f1a9..fd66bbe0b089 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
+++ b/WordPre... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderTagsFeedViewModelTest.kt
index 0db161ad16f8..84e494c2eb1d 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmod... | {
"org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest.Should map error TagFeedItem correctly": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.given no tags requested, when start, then UI state s... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20747 | wordpress-mobile | WordPress-Android | 20,747 | closed | [Tags IA] Integrate subfilters and post list in Tags Feed | Fixes #20669
- Refactor `SubFilterViewModel` to move relevant observers to `ReaderFragment` and be able to reuse it properly in Tags Feed
- Fix subfilter in the top bar for Tags Feed
- Implement the tag pills and "view more" feed button actions
- Implement functionality to show the post list for selected/filtere... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "93317754fd5f79711bd32e54a9c8de9234c09689"
} | [
{
"number": 20669,
"title": "[Reader] Implement \"More from <tag>\" row",
"body": "UI already implemented on https://github.com/wordpress-mobile/WordPress-Android/pull/20686"
}
] | kotlin | [Reader] Implement "More from <tag>" row
UI already implemented on https://github.com/wordpress-mobile/WordPress-Android/pull/20686
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20747 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20669"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.subfilter.SubFilterViewModelProviderTest" --tests "org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest" --tests "org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt
index eb8a55d29038..474ef518d722 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt
+++ b/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/ReaderTestUtils.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/ReaderTestUtils.kt
new file mode 100644
index 000000000000..99c7fe6e3ac5
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress/android/ui/reader/ReaderTestUtils.kt
@@ -0,... | {
"org.wordpress.android.ui.reader.viewmodels.tagsfeed.ReaderTagsFeedUiStateMapperTest.Should map error TagFeedItem correctly": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderTagsFeedViewModelTest.given no tags requested, when start, then UI state s... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20745 | wordpress-mobile | WordPress-Android | 20,745 | closed | Fix: Null Pointer Exception in PublishSettingsViewModel | Fixes #20272
This PR fixes a NPE when accessing `EditPostRepository.dateCreated`. The getter for `dateCreated` uses a `post!!` which will throw a NPE if the post is null. This PR replaces the use of `let` with `takeIf { it.hasPost() } `to ensure we don't call dateCreated when there is no post.
-----
## To Tes... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "3be32dad0b5dbc6c12e47d03d1cf2196fee416fc"
} | [
{
"number": 20272,
"title": "NullPointerException",
"body": "Sentry Issue: [JETPACK-ANDROID-JPV](https://a8c.sentry.io/issues/5004070666/?referrer=github_integration)\n\n```\nNullPointerException: None\n at org.wordpress.android.ui.posts.EditPostRepository.getDateCreated(EditPostRepository.kt:86)\n ... | kotlin | NullPointerException
Sentry Issue: [JETPACK-ANDROID-JPV](https://a8c.sentry.io/issues/5004070666/?referrer=github_integration)
```
NullPointerException: None
at org.wordpress.android.ui.posts.EditPostRepository.getDateCreated(EditPostRepository.kt:86)
at org.wordpress.android.ui.posts.PublishSettingsViewModel.... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20745 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20272"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PublishSettingsViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PublishSettingsViewModel.kt
index 6b9ac3478a36..0c3a87edcbef 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/PublishSettingsViewModel.kt
+++ b/Word... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditPostPublishSettingsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/EditPostPublishSettingsViewModelTest.kt
index ff79f33bbd8f..ecd6b449465b 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditPostPublis... | {
"org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest.on start sets current date when post not present": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest.DISABLES notification when publish date in NOW": {
"run":... | {
"org.wordpress.android.ui.posts.EditPostPublishSettingsViewModelTest.on publishNow updates published date": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
wordpress-mobile__WordPress-Android-20658 | wordpress-mobile | WordPress-Android | 20,658 | closed | Conflict Resolution: Tracking source | Fixes #20655
This PR adds a source property to the Post Conflict Resolution tracking events
"source=page|post"
Merge Instructions
- Ensure PR #20635 has been merged
- Remove Not Ready for merge label
- Merge as normal
-----
## To Test:
Prereq
- Install and launch the app from this PR
- Set up some ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "69b26252a8a4e555814a793806146f95ca36d274"
} | [
{
"number": 20655,
"title": "Add indicator to the conflict resolution overlay track events so post can be distinguished from page",
"body": "Add property \"source=page|post\" to the overlay tracking events"
}
] | kotlin | Add indicator to the conflict resolution overlay track events so post can be distinguished from page
Add property "source=page|post" to the overlay tracking events
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20658 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20655"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.PostResolutionOverlayViewModelTest" --tests "org.wordpress.android.ui.posts.PostResolutionOverlayAnalyticsTrackerTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResolutionOverlayAnalyticsTracker.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResolutionOverlayAnalyticsTracker.kt
index 009fa4247147..dd22ea67f638 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostResoluti... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/PostResolutionOverlayAnalyticsTrackerTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/PostResolutionOverlayAnalyticsTrackerTest.kt
index 54b47bd72f08..651577665d20 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/Post... | {
"org.wordpress.android.ui.posts.PostResolutionOverlayAnalyticsTrackerTest.given page, tracksDismiss tracks correct event": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.PostResolutionOverlayViewModelTest.when on close click, then dialog dismiss event is posted": {... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20600 | wordpress-mobile | WordPress-Android | 20,600 | closed | Display tags chip in subscriptions feed based on tags feed feature flag | > [!WARNING]
> ~Should be merged after https://github.com/wordpress-mobile/WordPress-Android/pull/20596~
Fixes #20594
-----
## To Test:
- Install JP and sign in.
- Enable remote feature `reader_tags_feed`.
- Open "Reader".
- Select "Subscriptions" feed.
- 🔍 The "Tags" chip should not be displayed..... | {
"label": "wordpress-mobile:feature/tags-ia",
"ref": "feature/tags-ia",
"sha": "33927465b6f3df7a3fcea60a25408c2db1f66086"
} | [
{
"number": 20594,
"title": "[Reader] Hide \"Tags\" chip from \"Subscriptions\" feed (behind FF)",
"body": null
}
] | kotlin | [Reader] Hide "Tags" chip from "Subscriptions" feed (behind FF)
| Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20600 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20594"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt
index 23e1b6835c44..f8e1861e7984 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt
+++ b/WordPress/src/main/java/org/wor... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewModelTest.kt
index bb9c557587bd..ccfb6f7479a3 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/viewmodels/ReaderViewMo... | {
"org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest.Last selected tab is stored into shared preferences": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.viewmodels.ReaderViewModelTest.UiState is NOT updated with content state when loaded tags are empty... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20589 | wordpress-mobile | WordPress-Android | 20,589 | closed | [Stats] Add year to date picker for weeks. | Fixes #20488
Add year to the week granularity label in datepicker. The screenshot below is on a small screen width.
Note: this affects both the stats that is currently out to everyone and the traffic tab under the week granularity.
![Screenshot_20240403_172130](https://github.com/wordpress-mobile/WordPress-And... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "15001b97f4b68c77e9a68e6b8a35f47748220daa"
} | [
{
"number": 20488,
"title": "Stats Traffic tab dates should include year",
"body": "### Expected behavior\r\nThe date shown on the Stats Traffic tab when \"By week\" is selected should include the year to avoid confusion about which year is being displayed. (e.g. \"Feb 19 - Feb 25, 2024\")\r\n\r\nDiscus... | kotlin | Stats Traffic tab dates should include year
### Expected behavior
The date shown on the Stats Traffic tab when "By week" is selected should include the year to avoid confusion about which year is being displayed. (e.g. "Feb 19 - Feb 25, 2024")
Discussed in:
- p1709586750284709/1709585366.152709-slack-C06BR07TJHK
... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
| https://github.com/wordpress-mobile/WordPress-Android/pull/20589 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20488"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.stats.refresh.utils.StatsDateFormatterTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/utils/StatsDateFormatter.kt b/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/utils/StatsDateFormatter.kt
index b262f70dfc04..4ae0d0607848 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/utils/StatsDat... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/StatsDateFormatterTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/StatsDateFormatterTest.kt
index f06c4b71e7cc..000d42ebf933 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/utils/... | {
"org.wordpress.android.ui.stats.refresh.utils.StatsDateFormatterTest.prints negative UTC when site timezone does not match current timezone and site timezone is negative GMT": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.stats.refresh.utils.StatsDateFormatterTest.print... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20572 | wordpress-mobile | WordPress-Android | 20,572 | closed | Handles site successfully fetched but has not been found in the local db | Fixes #20530
**Depends on:** https://github.com/wordpress-mobile/WordPress-Android/pull/20571
## Description
This PR adds a new error UI state to gracefully handle an unexpected error in the site creation preview screen were the site successfully fetched but has not been found in the local db.
-----
## To ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "20ce089204504f657a44bc4e7b1952f821f27666"
} | [
{
"number": 20530,
"title": "IllegalArgumentException: Site successfully fetched but has not been found in the local db.",
"body": "Sentry Issue: [JETPACK-ANDROID-DYR](https://a8c.sentry.io/issues/4584154681/?referrer=github_integration)\n\n```\nIllegalArgumentException: Site successfully fetched but ha... | kotlin | IllegalArgumentException: Site successfully fetched but has not been found in the local db.
Sentry Issue: [JETPACK-ANDROID-DYR](https://a8c.sentry.io/issues/4584154681/?referrer=github_integration)
```
IllegalArgumentException: Site successfully fetched but has not been found in the local db.
at org.wordpress.andr... | Thanks for reporting! 👍 <!-- generated_by_dangermattic -->
Possibly related to this older fixed bug https://github.com/wordpress-mobile/WordPress-Android/issues/11394
Looking at the breadcrumbs the error usually follows a DB error _[Can't insert WP.com site [some site], missing user account](https://github.com/wordpr... | https://github.com/wordpress-mobile/WordPress-Android/pull/20572 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20530"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/previews/SitePreviewViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/previews/SitePreviewViewModel.kt
index 8383d1625288..84f96ab53e6c 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/preview... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/previews/SitePreviewViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/previews/SitePreviewViewModelTest.kt
index e5a0051b219f..b1ed67de828e 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/sitecreation... | {
"org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModelTest.on start if site is created but cannot be retrieved from fb fails show error": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModelTest.on start does not show pr... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20571 | wordpress-mobile | WordPress-Android | 20,571 | closed | Show error when the site is not created correctly | Fixes #19791
## Description
This PR adds a new error UI state to gracefully handle an unexpected error in the site creation preview screen were the site appears not created.
-----
## To Test:
Since I was not able to reproduce the error in real conditions I added a test and faked the state with an
[error.pat... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "a007b490867cb5e64f8b33539f8b17aab32ea051"
} | [
{
"number": 19791,
"title": "IllegalArgumentException: Failed requirement.",
"body": "Sentry Issue: [JETPACK-ANDROID-ETT](https://a8c.sentry.io/issues/4644782022/?referrer=github_integration)\n\n```\nIllegalArgumentException: Failed requirement.\n at org.wordpress.android.ui.sitecreation.previews.Sit... | kotlin | IllegalArgumentException: Failed requirement.
Sentry Issue: [JETPACK-ANDROID-ETT](https://a8c.sentry.io/issues/4644782022/?referrer=github_integration)
```
IllegalArgumentException: Failed requirement.
at org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModel.start(SitePreviewViewModel.kt:84)
at o... | Might want to investigate replacing `require` with a conditional check and gracefully exit rather than exception.
- This crash started to occur when we re-enabled the domain selection step in the site creation flow.
- It occurs mostly on low-memory devices.
- It occurs when the app is in the background. See `{"phase"... | https://github.com/wordpress-mobile/WordPress-Android/pull/20571 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19791"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/previews/SiteCreationPreviewFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/sitecreation/previews/SiteCreationPreviewFragment.kt
index 0ce6f7a2830f..8ab86f82a9d1 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/sitecr... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/previews/SitePreviewViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/sitecreation/previews/SitePreviewViewModelTest.kt
index 8d1d17845f05..e5a0051b219f 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/sitecreation... | {
"org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModelTest.on ok button click is propagated": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitecreation.previews.SitePreviewViewModelTest.on start show error when result is not created": {
"run": "NONE",... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20103 | wordpress-mobile | WordPress-Android | 20,103 | closed | [Reader IA] Show onboarding for users with no tags or dailyprompt tag only | Fixes #20091
Ignores the `dailyprompt` tag when checking for the subscribed tags to show the Discover Onboarding / Choose your interests (onboarding) screens.
-----
## To Test:
### Requirements
Create a new account to run the test (`dailyprompt` tag auto-injected by default) or prepare an existing account... | {
"label": "wordpress-mobile:feature/reader-ia",
"ref": "feature/reader-ia",
"sha": "eeec54055af88943943cebf98b94519a527e1c7a"
} | [
{
"number": 20091,
"title": "[Reader IA] Bring back the Discover Onboarding for new users",
"body": "When a new user entered the Reader for the first time we would show the `Discover` feed with a \"Welcome\" message and a button leading to a \"Choose your topics\" screen, which essentially followed thos... | kotlin | [Reader IA] Bring back the Discover Onboarding for new users
When a new user entered the Reader for the first time we would show the `Discover` feed with a "Welcome" message and a button leading to a "Choose your topics" screen, which essentially followed those tags and made Discover be populated with stuff based on th... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/20103 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20091"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.discover.interests.ReaderInterestsViewModelTest" --tests "org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModel.kt
index c9b02681ea84..2e7c7b954b95 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderDisc... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderDiscoverViewModelTest.kt
index 1db7219634ec..064409261b3c 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/discover/Re... | {
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.Scroll to top is triggered when discover feed is updated after swipe to refresh": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.ShowFollowInterestsEmptyUiSt... | {
"org.wordpress.android.ui.reader.discover.ReaderDiscoverViewModelTest.When user clicks on video overlay post action handler is invoked": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.wordpress.android.ui.reader.discover.interests.ReaderInterestsViewModelTest.interest selected if onInterestAtIndexToggled invoked on a deselected interest": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.discover.interests.ReaderInterestsViewModelTest.snackba... | {} |
wordpress-mobile__WordPress-Android-20094 | wordpress-mobile | WordPress-Android | 20,094 | closed | Implements: Pull to refresh in Site Monitor Tabs | ## Closes
#20088
## Description
This PR implements pull to refresh functionality in Site monitor Screen
## Screenshots
[Screen_recording_20240201_124924.webm](https://github.com/wordpress-mobile/WordPress-Android/assets/17463767/a3946842-df17-423e-b585-d932dccfc5ab)
## To Test:
#### Prerequisite
<deta... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "96b6b967f9b1e3361f79b71ace7db56facd2397c"
} | [
{
"number": 20088,
"title": "Site Monitor: Add pull-to-refresh",
"body": "Add Pull-to-refresh to the Webview pages"
}
] | kotlin | Site Monitor: Add pull-to-refresh
Add Pull-to-refresh to the Webview pages
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/20094 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/20088"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.sitemonitor.SiteMonitorParentViewModelTest" --tests "org.wordpress.android.ui.sitemonitor.SiteMonitorTabViewModelSliceTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/sitemonitor/SiteMonitorParentActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/sitemonitor/SiteMonitorParentActivity.kt
index 3c015c61d3be..97278d29fc62 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/sitemonitor/SiteMonitorParentA... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/sitemonitor/SiteMonitorParentViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/sitemonitor/SiteMonitorParentViewModelTest.kt
index 411f72a9a442..98d3ddf0e3a1 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/sitemonitor/SiteMoni... | {
"org.wordpress.android.ui.sitemonitor.SiteMonitorParentViewModelTest.given php logs, when onWebViewError is invoked, then php logs vm slice onWebViewError is invoked": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.sitemonitor.SiteMonitorParentViewModelTest.given metrics... | {} | {} | {} |
wordpress-mobile__WordPress-Android-20057 | wordpress-mobile | WordPress-Android | 20,057 | closed | [Reader IA] Add "Followed P2s" item to dropdown menu | Fixes #19898
-----
## To Test:
- Install JP and sign in with an account that has followed P2s and is not associated with A8C
- Open the Reader: you should see the `Followed P2s` item in the dropdown menu
<img width="211" alt="image" src="https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/... | {
"label": "wordpress-mobile:feature/reader-ia",
"ref": "feature/reader-ia",
"sha": "e01610c0eaaccf7a8b20976ca58a628ee6efcce8"
} | [
{
"number": 19898,
"title": "[Reader IA - Bug] Followed P2s feed not showing in drop-down",
"body": "\r\n\r\n>While comparing the viewpager tabs and feeds content for before / after, I see... | kotlin | [Reader IA - Bug] Followed P2s feed not showing in drop-down
>While comparing the viewpager tabs and feeds content for before / after, I see a missing menu item for "Followed P2S" (that is a filterabl... | We should also consider adding the analytics event for when this menu item is clicked. | https://github.com/wordpress-mobile/WordPress-Android/pull/20057 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19898"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderConstants.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderConstants.java
index 504d71f1de01..c0798c5824ca 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderConstants.java
+++ b/WordPress/src/main/jav... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarMenuHelperTest.kt
index b8a4180dff9d..0279f25bee2d 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/reader/utils/ReaderTopBarM... | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN discover not present WHEN createMenu THEN discover menu item not created": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN custom lists not present WHEN c... | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN a8c not present WHEN createMenu THEN a8c menu item not created": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN single menu item built with helper WHEN getReaderTagIndexFromMenuItem then return correct index": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.reader.utils.ReaderTopBarMenuHelperTest.GIVEN liked no... | {} |
wordpress-mobile__WordPress-Android-19834 | wordpress-mobile | WordPress-Android | 19,834 | closed | 🤖 [Dynamic Cards] Makes the whole card actionable | Fixes #19833
## Description
Makes the whole card actionable when there is a valid action url.
-----
## To Test:
### Domains management card
* **Verify** that the button is actionable and the `dynamic_dashboard_card_cta_tapped` event is emmitted.
* **Verify** that the whole card is actionable and the `dynam... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "846db4fdadb6270047b08fe2ced34856c2078194"
} | [
{
"number": 19833,
"title": "🤖 [Dynamic Cards] Make the whole card actionable",
"body": "The whole card should be actionable when there is a valid action url\n\nSlack conversation: p1703156111412259/1702977446.551109-slack-C067H36F011"
}
] | kotlin | 🤖 [Dynamic Cards] Make the whole card actionable
The whole card should be actionable when there is a valid action url
Slack conversation: p1703156111412259/1702977446.551109-slack-C067H36F011
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19834 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19833"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItem.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItem.kt
index 981eb1d64c54..81026f4db9a4 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteCardAndItem.kt
+++ b/WordPress/src/main/jav... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dynamiccard/DynamicCardsBuilderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dynamiccard/DynamicCardsBuilderTest.kt
index a4284372ad73..23f7dc822998 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/c... | {
"org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest.WHEN the card remote feature flag is disabled THEN the card is not visible": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest.WHEN the card has inval... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19818 | wordpress-mobile | WordPress-Android | 19,818 | closed | Plans on site domain display updated card | Fixes #19807, #19808, #19809
Updates card with `upgrade to a plan` CTA, besides existing `get a domain` CTA on domains dashboard for those on free plan .
| Before | After |
|--------|--------|
| ![Screenshot_20231219_193130](https://github.com/wordpress-mobile/WordPress-Android/assets/990349/1a127106-0ed5-49... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "22a0dff9916dc23c05469180253af5edaab8d497"
} | [
{
"number": 19807,
"title": "[Android] Display a card on Site domain",
"body": "Apply same conditions for displaying plans card on My site dashboard\n\n\n\n"
}
] | kotlin | [Android] Display a card on Site domain
Apply same conditions for displaying plans card on My site dashboard
|
<!--
1 failure: Please add a type...
0 warning:
DangerID: danger-id-Peril;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>
Please add a type label to this ... | https://github.com/wordpress-mobile/WordPress-Android/pull/19818 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19807"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.DomainsDashboardViewModelTest" | diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index 6fd3d4672b24..1b72edaa59ee 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -3,6 +3,7 @@
24.0
-----
* [*] Filter media types when sharing files to the editor [https://github.com/wordpress-mobile/WordPress-Android/pull/19754]
+* [***] [Jetpack-only] Pl... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainsDashboardViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainsDashboardViewModelTest.kt
index 2f474eb5c510..e7dc96542b70 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/domains/DomainsDashboardViewMo... | {
"org.wordpress.android.ui.domains.DomainsDashboardViewModelTest.free plan with no custom domains": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.DomainsDashboardViewModelTest.paid plan with custom domains and credits": {
"run": "PASS",
"test": "NONE",
... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19804 | wordpress-mobile | WordPress-Android | 19,804 | closed | [Dynamic Cards] Hide dynamic card through a card menu | Fixes #19776
This PR includes a dynamic card's dropdown menu UI and local hiding dynamic cards logic.
-----
## To Test:
- Apply this patch: [cardmockspatch.patch](https://gith... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "c016a06faabe96d1e35c90e89321afd4598e2399"
} | [
{
"number": 19776,
"title": "🤖 [Dynamic Cards] Dismissing card from a dropdown menu",
"body": "After tapping on the ••• menu, a dropdown menu should appear with a \"hiding the card\" option. After tapping on the card it has to be removed from the screen permanently.\n\n![Image](https://github.com/wordp... | kotlin | 🤖 [Dynamic Cards] Dismissing card from a dropdown menu
After tapping on the ••• menu, a dropdown menu should appear with a "hiding the card" option. After tapping on the card it has to be removed from the screen permanently.
![Image](https://github.com/wordpress-mobile/WordPress-Android/assets/16563318/260eec1f-03fd-... | Hi,
I want to work on this issue.
> Hi,
> I want to work on this issue.
Thank you for offering to help on this @malirauf 🙇
Since this issue is part of a feature that is still work in progress it might be hard to coordinate on the implementation. Would you like to have a look at [an issue from this list ](https:... | https://github.com/wordpress-mobile/WordPress-Android/pull/19804 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19776"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsViewModelSliceTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt
index 68af2a267ddf..1d6db4d0c792 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteViewModel.kt
+++ b/WordPress/src/main/java/org/... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dynamiccard/DynamicCardsViewModelSliceTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dynamiccard/DynamicCardsViewModelSliceTest.kt
index 2a0628a5429b..2528fad23c30 100644
--- a/WordPress/src/test/java/org/wordpress/andro... | {
"org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsViewModelSliceTest.WHEN get builder params THEN return only not hidden cards only": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsViewModelSliceTest.WHEN card hide menu i... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19801 | wordpress-mobile | WordPress-Android | 19,801 | closed | 🤖 [Dynamic Cards] Implement card display logic according to the remote feature flags | Fixes #19797
## Description
This PR checks the remote feature flag key of each card returned from the endpoint and:
* If the key exists in the remote feature flags endpoint response, the remote flag value controls the card visibility
* If the key doesn’t exist, it means there are no restrictions, and the card is ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "73fc0a20cb7f0b614da2a8e3fe82d382518a0ec1"
} | [
{
"number": 19797,
"title": "🤖 [Dynamic Cards] Implement card display logic according to the remote feature flags",
"body": "When parsing the remote cards data, we will check the value of the remote-feature-flag against the remote feature flags endpoint response. If the key exists in the remote feature... | kotlin | 🤖 [Dynamic Cards] Implement card display logic according to the remote feature flags
When parsing the remote cards data, we will check the value of the remote-feature-flag against the remote feature flags endpoint response. If the key exists in the remote feature flags endpoint response, we will respect the value retu... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19801 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19797"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.kt
index 9339b1d9abe8..33b3aa292daa 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.k... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dynamiccard/DynamicCardsBuilderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dynamiccard/DynamicCardsBuilderTest.kt
index 301a867dabb3..f6e664ba74b3 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/c... | {
"org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest.WHEN the card remote feature flag does not exist THEN the card is visible": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest.WHEN the card has invali... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19790 | wordpress-mobile | WordPress-Android | 19,790 | closed | 🤖 [Dynamic Cards] Ordering logic | Fixes #19739
## Description
This PR builds the UI models in the right order/position from the API response.
Note: I added a separate issue for the remote feature flag display logic to avoid extending this PR more https://github.com/wordpress-mobile/WordPress-Android/issues/19797
-----
## To Test:
- Apply ... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "f114825b2c66071a6dc94ed01320012ec2089c83"
} | [
{
"number": 19739,
"title": "🤖 [Dynamic Cards] Ordering logic",
"body": "Order type `top` cards will be sorted to the beginning of the card list.\nOrder type `bottom` cards will be sorted to the end of the card list."
}
] | kotlin | 🤖 [Dynamic Cards] Ordering logic
Order type `top` cards will be sorted to the beginning of the card list.
Order type `bottom` cards will be sorted to the end of the card list.
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19790 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19739"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dynamiccard.DynamicCardsBuilderTest" --tests "org.wordpress.android.ui.mysite.MySiteViewModelTest" --tests "org.wordpress.android.ui.mysite.cards.dashboard.CardsBuilderTest" --tests "org.wordpress.android.ui.mysite.car... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapterDiffCallback.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapterDiffCallback.kt
index 207d40c6055b..6f4e178089c9 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapterDiffCallback.kt
+++ ... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
index 1610b066b8f0..4ebeb51b285e 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
+++ b/WordPress/src/te... | {
"org.wordpress.android.ui.mysite.cards.CardsBuilderTest.given quick start in progress, when site is selected, then QS card built": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.MySiteViewModelTest.when domain registration card is shown, then card shown event is t... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19773 | wordpress-mobile | WordPress-Android | 19,773 | closed | [Dynamic Cards] Update Endpoint Response | Fixes #19734
-----
## Description
This PR adds Dynamic Cards support in the dashboard/cards-data Endpoint Response.
Note:
* Adding the `Not Ready for Merge` status till we test with the backend, merge the accompanying FluxC PR and update the reference to point to `trunk`
## To Test:
* Enable https://git... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "3c7e9ce41201e596600a3e4f56b873880c229d5a"
} | [
{
"number": 19734,
"title": "[Dynamic Cards] Update Endpoint Response",
"body": "### Endpoint\r\n`sites/{SITE_ID}/dashboard/cards-data`\r\n\r\n### The Full Response: \r\n```\r\n{\r\n \"todays_stats\": {...},\r\n \"posts\": {...},\r\n \"pages\": [...],\r\n \"activity\": {...},\r\n \"dynamic\": [Card... | kotlin | [Dynamic Cards] Update Endpoint Response
### Endpoint
`sites/{SITE_ID}/dashboard/cards-data`
### The Full Response:
```
{
"todays_stats": {...},
"posts": {...},
"pages": [...],
"activity": {...},
"dynamic": [Card, Card, ...]
}
```
### The Card Object:
```
{
"id": "year_in_review_2023",
... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19773 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19734"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dashboard.CardsSourceTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.kt
index 182673578d15..9339b1d9abe8 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSource.k... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSourceTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/CardsSourceTest.kt
index 01014309a99e..08c87200a9f7 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/Cards... | {
"org.wordpress.android.ui.mysite.cards.dashboard.CardsSourceTest.given activity feature disabled, when refresh is invoked, then activity not requested": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dashboard.CardsSourceTest.given invalid site, when refresh... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19741 | wordpress-mobile | WordPress-Android | 19,741 | closed | In-app reviews | Fixes #12605
This adds [in-app reviews feature](https://developer.android.com/guide/playcore/in-app-review). The prompt will display after the second successful publishing (post or story). It must be a new post, and editing doesn't count.
https://github.com/wordpress-mobile/WordPress-Android/assets/2471769/491... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "5f832ec3ba4b9fcd15c988a71fc458e11ac88c13"
} | [
{
"number": 12605,
"title": "Add an in-app review prompt",
"body": "Google recently released a [new In-App Review API for Google Play reviews](https://android-developers.googleblog.com/2020/08/in-app-review-api.html). From their [developer docs](https://developer.android.com/guide/playcore/in-app-review... | kotlin | Add an in-app review prompt
Google recently released a [new In-App Review API for Google Play reviews](https://android-developers.googleblog.com/2020/08/in-app-review-api.html). From their [developer docs](https://developer.android.com/guide/playcore/in-app-review):
> The Google Play In-App Review API lets you promp... | This is cool! I'd suggest making the prompt appear after user successfully publishes a new post or page.
We already implement the existing app rating system – @khaykov, would you be able to take a quick look and see how different this is from what we use already?
@frosty It is pretty different. Currently, we just show ... | https://github.com/wordpress-mobile/WordPress-Android/pull/19741 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/12605"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.review.ReviewViewModelTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index a982ada743d9..fef136d1799e 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -421,6 +421,8 @@ dependencies {
implementation "androidx.lifecycle:lifecycle-livedata-ktx:$androidxLifecycleVersion"
implementation "androidx.lifecy... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/review/ReviewViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/review/ReviewViewModelTest.kt
new file mode 100644
index 000000000000..be459d325fe5
--- /dev/null
+++ b/WordPress/src/test/java/org/wordpress/android/ui/review/ReviewViewModelTe... | {
"org.wordpress.android.ui.review.ReviewViewModelTest.onPublishingPost_whenInAppReviewsAlreadyShown_doNotLaunchInAppReviews": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.review.ReviewViewModelTest.onPublishingPost_whenPublishedCountIsHigh_launchInAppReviews": {
"ru... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19730 | wordpress-mobile | WordPress-Android | 19,730 | closed | [Prompts] Fix response list paging regression | Fixes #19728
The correct code was already in production until the release of 23.7, when it was removed because of an old PR (created before the correct code fix was merged in the past) that was rebased and I didn't realize it reverted to the wrong behavior.
PR that introduced the regression: https://github.com/wo... | {
"label": "wordpress-mobile:release/23.8",
"ref": "release/23.8",
"sha": "afd37fc83bb4a9b7da872e8be4669de73baf858d"
} | [
{
"number": 19728,
"title": "[Prompts] Regression in Prompts responses list pagination",
"body": "### Expected behavior\r\nWhen tapping the `View all responses` and scrolling the response list I should be able to get an infinite scroll with proper pagination until I see all responses. New posts are adde... | kotlin | [Prompts] Regression in Prompts responses list pagination
### Expected behavior
When tapping the `View all responses` and scrolling the response list I should be able to get an infinite scroll with proper pagination until I see all responses. New posts are added to the end of the list when loaded. (it was working on v... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19730 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19728"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.bloggingprompts.BloggingPromptsPostTagProviderTest" | diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
index f7ef4c88e694..1d298b006c2f 100644
--- a/RELEASE-NOTES.txt
+++ b/RELEASE-NOTES.txt
@@ -11,6 +11,7 @@
* [*] Block Editor: In the deeply nested block warning, only display the ungroup option for blocks that support it [https://github.com/WordPress/gutenberg/pull/56... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/BloggingPromptsPostTagProviderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/BloggingPromptsPostTagProviderTest.kt
index 8c901817c0f7..942681c91225 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/blog... | {} | {
"org.wordpress.android.ui.bloggingprompts.BloggingPromptsPostTagProviderTest.Should return the expected ReaderTag when promptIdSearchReaderTag is called": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.wordpress.android.ui.bloggingprompts.BloggingPromptsPostTagProviderTest.Should return the generic tag when promptIdTag is called given invalid url": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.bloggingprompts.BloggingPromptsPostTagProviderTest.Should return the e... | {} |
wordpress-mobile__WordPress-Android-19721 | wordpress-mobile | WordPress-Android | 19,721 | closed | [SotW 2023] Add State of the Word post-event card to WordPress | Fixes #19709
More info in the parent issue. The card is only visible for the following requirements:
- The app is WordPress (part of the `WpSotw2023NudgeFeatureConfig` logic)
- The `wp_sotw_2023_nudge` flag is ON (`WpSotw2023NudgeFeatureConfig`)
- The user did not hide the card (App Pref set by user interaction w... | {
"label": "wordpress-mobile:release/23.8",
"ref": "release/23.8",
"sha": "0a3337b25917c0a74a6065ccc628279b34f8f8f4"
} | [
{
"number": 19709,
"title": "SoTW 2023 card in the WordPress app",
"body": "Internal ref: pdb1SS-3F9-p2\r\n\r\nSince we currently don't have a way of showing informational nudges/cards in the WordPress app, we will add a static card for inviting the users to check the State of the Word keynote event rec... | kotlin | SoTW 2023 card in the WordPress app
Internal ref: pdb1SS-3F9-p2
Since we currently don't have a way of showing informational nudges/cards in the WordPress app, we will add a static card for inviting the users to check the State of the Word keynote event recording.
We'll add a simple card for SoTW in the WordPre... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19721 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19709"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.sotw2023.WpSotw2023NudgeCardAnalyticsTrackerTest" --tests "org.wordpress.android.ui.mysite.cards.sotw2023.WpSotw2023NudgeCardViewModelSliceTest" --tests "org.wordpress.android.ui.mysite.cards.dashboard.todaysstats.Toda... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapter.kt b/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapter.kt
index 913f4e1557aa..6453339350c6 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/mysite/MySiteAdapter.kt
+++ b/WordPress/src/main/java/org/wordpr... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
index 74610d76f6ff..54beb07c7607 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteViewModelTest.kt
+++ b/WordPress/src/te... | {
"org.wordpress.android.ui.mysite.MySiteViewModelTest.when domain registration card is shown, then card shown event is tracked": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.MySiteViewModelTest.given site menu built, when dashboard cards items, then qs card not e... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19708 | wordpress-mobile | WordPress-Android | 19,708 | closed | QR Code: Partial MLKit Revert | Fixes #19695
This PR reverts the use of MLKit for scanning QR Code as used by the web login. The reason for the revert is because the `stories-android` has a dependency on camerax `1.0.0-alpha06' and the MLKit needs at least version '1.2.3'. We could not resolve the dependency via gradle :(.
The entire `barcodes... | {
"label": "wordpress-mobile:release/23.8",
"ref": "release/23.8",
"sha": "c2913b6a1553d9c6646ffe2990be1f4898a15581"
} | [
{
"number": 19695,
"title": "RuntimeException: Unable to start activity ComponentInfo{com.jetpack.android/org.wordpress.android.ui.stories.Story...",
"body": "Sentry Issue: [JETPACK-ANDROID-FBG](https://a8c.sentry.io/issues/4681256402/?referrer=github_integration)\n\n```\nClassNotFoundException: android... | kotlin | RuntimeException: Unable to start activity ComponentInfo{com.jetpack.android/org.wordpress.android.ui.stories.Story...
Sentry Issue: [JETPACK-ANDROID-FBG](https://a8c.sentry.io/issues/4681256402/?referrer=github_integration)
```
ClassNotFoundException: androidx.camera.core.CameraX$LensFacing
at com.automattic.phot... | I was able to reproduce this crash on in debug mode on a Pixel 5 (Android 14) just by trying to create a new story.
Pasting the full stack trace below:
```
FATAL EXCEPTION: main
Process: com.jetpack.android.beta, PID: 11027
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jetpack.android.beta... | https://github.com/wordpress-mobile/WordPress-Android/pull/19708 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19695"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.qrcodeauth.QRCodeAuthViewModelTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index 0b810da286a3..a52831f4e084 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -420,14 +420,8 @@ dependencies {
implementation "androidx.lifecycle:lifecycle-process:$androidxLifecycleVersion"
implementation "com.android.volley:... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/qrcodeauth/QRCodeAuthViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/qrcodeauth/QRCodeAuthViewModelTest.kt
index 6088a7c684c3..7ef417a884f2 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/qrcodeauth/QRCodeAuthViewModelTest.k... | {
"org.wordpress.android.ui.qrcodeauth.QRCodeAuthViewModelTest.given validated state, when authenticate invoked, then authenticating followed by done": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.qrcodeauth.QRCodeAuthViewModelTest.given authorization required with valid... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19656 | wordpress-mobile | WordPress-Android | 19,656 | closed | Removes category selection from page pre-publishing options | Fixes #19557
## Description
This PR removes category selection from page pre-publishing options aligning with the current options available on the web
|Before|After|... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "65f9f87a953f0f0d0f4bac8bd04ee02f9fcb2152"
} | [
{
"number": 19557,
"title": "Pages: When publishing pages you see the prepublish modal that tells you select catergoris",
"body": "### Expected behaviour\r\nYou should not see the prepublish modal and you should not be able to choose categories. \r\n\r\n### Actual behaviour\r\nYou see this. After you pu... | kotlin | Pages: When publishing pages you see the prepublish modal that tells you select catergoris
### Expected behaviour
You should not see the prepublish modal and you should not be able to choose categories.
### Actual behaviour
You see this. After you publish a page.
<img src="https://github.com/wordpress-mobile/Wor... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19656 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19557"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/prepublishing/home/PrepublishingHomeViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/prepublishing/home/PrepublishingHomeViewModel.kt
index 0004f8b6fae7..4d385373241d 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/po... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/PrepublishingHomeViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/PrepublishingHomeViewModelTest.kt
index 9ce9e6795e6b..9d861816c5bf 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/PrepublishingHomeViewModel... | {
"org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest.verify that publish action result is propagated from postSettingsUtils": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest.verify that if isStoryPost is true then StoryTitleU... | {
"org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest.verify that page home actions are propagated to prepublishingHomeUiState once the viewModel is started": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest.verify that PUBLISH... | {
"org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest.verify that tags action type is propagated to prepublishingActionType": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.PrepublishingHomeViewModelTest.verify that header ui state is propagated to prepubl... | {} |
wordpress-mobile__WordPress-Android-19603 | wordpress-mobile | WordPress-Android | 19,603 | closed | [Bloganuary] Add attribution property to dashboard card tracking | Fixes #19594
-----
## To Test:
- Install Jetpack and log in;
- Open "My Site" -> "HOME" with a blog selected;
- Verify the Blogging Prompts card is visible;
- Verify the track log is shown: `🔵 Tracked: blogging_prompts_my_site_card_viewed` **with the property** `"attribution"`;
- Tap `"Answer prompt` but... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "9fc79ceb9a6bcbdaa7adfd45dd9e6f80636120a6"
} | [
{
"number": 19594,
"title": "[Prompts] Add attribution property to dashboard card tracking",
"body": "- update `blogging_prompts_my_site_card_viewed`\r\n - add property for `attribution` (none, `dayone`, `bloganuary`)\r\n- update `blogging_prompts_my_site_card_answer_prompt_tapped`\r\n - add property ... | kotlin | [Prompts] Add attribution property to dashboard card tracking
- update `blogging_prompts_my_site_card_viewed`
- add property for `attribution` (none, `dayone`, `bloganuary`)
- update `blogging_prompts_my_site_card_answer_prompt_tapped`
- add property for `attribution` (none, `dayone`, `bloganuary`)
- update `my... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19603 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19594"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dashboard.bloggingprompts.BloggingPromptCardViewModelSliceTest" --tests "org.wordpress.android.viewmodel.main.WPMainActivityViewModelTest" --tests "org.wordpress.android.ui.mysite.BloggingPromptsCardTrackHelperTest" --... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/main/CompactBloggingPromptCardViewHolder.kt b/WordPress/src/main/java/org/wordpress/android/ui/main/CompactBloggingPromptCardViewHolder.kt
index b6793405407a..8d9fb79b03ed 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/main/CompactBloggingProm... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/BloggingPromptsCardTrackHelperTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/BloggingPromptsCardTrackHelperTest.kt
index 158deabf14eb..253bc5a805a4 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/mysite/BloggingPrompts... | {
"org.wordpress.android.viewmodel.main.WPMainActivityViewModelTest.CREATE_NEW_POST action sets task as done in QuickStartRepository": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.MySiteViewModelTest.when domain registration card is shown, then card shown event is... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19597 | wordpress-mobile | WordPress-Android | 19,597 | closed | Handle webview checkout result | Fixes #19544
### Description
This PR adds completion handling for the domain purchase flow (webview checkout). When the checkout result is an error state, a generic error screen is shown (same as the existing screen for cart failure). On success, the "all domains" screen is shown (and activities in the back stack... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "c1e694406e5c0746b55ff2533d8ada84dad2b02a"
} | [
{
"number": 19544,
"title": "🤖 Handle webview checkout result",
"body": "When the domain purchase is complete in the domain management flow:\n* On success the flow returns to a refreshed domain management list\n* On failure an error is shown"
}
] | kotlin | 🤖 Handle webview checkout result
When the domain purchase is complete in the domain management flow:
* On success the flow returns to a refreshed domain management list
* On failure an error is shown
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19597 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19544"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.management.purchasedomain.PurchaseDomainViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java b/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java
index b789b372eb11..6722836cd815 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/ActivityLauncher.java
+++ b/WordPress/src/main/java/org/wordpress/an... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/management/purchasedomain/PurchaseDomainViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/management/purchasedomain/PurchaseDomainViewModelTest.kt
index d21bbbb02c47..2fd151dd855b 100644
--- a/WordPress/src/test/java/org/wor... | {
"org.wordpress.android.ui.domains.management.purchasedomain.PurchaseDomainViewModelTest.WHEN a site is chosen THEN the ui is set to the SubmittingSiteDomainCart state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.purchasedomain.PurchaseDomainViewMod... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19593 | wordpress-mobile | WordPress-Android | 19,593 | closed | [Bloganuary] Show prompts bloganuary attribution UI | Fixes #19592
When the prompts for today contains `bloganuary` in the `attribution` field we should show the proper icon and text in the attribution UI (the same we use for Day One).
**Note:** This still does not implement the updated UI, just reuses the attribution logic for the card.
![image](https://github.... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "fd048f2cc46fddf2cede17ecaa0abc5543a23c82"
} | [
{
"number": 19592,
"title": "[Bloganuary] Implement the Bloganuary attribution UI in Prompts card",
"body": "We are internally talking about returning the value `bloganuary` in the `attribution` field of the API response as we do for Day One (which returns `dayone`).\n\nInternal ref: pe7F0s-1iI-p2#comme... | kotlin | [Bloganuary] Implement the Bloganuary attribution UI in Prompts card
We are internally talking about returning the value `bloganuary` in the `attribution` field of the API response as we do for Day One (which returns `dayone`).
Internal ref: pe7F0s-1iI-p2#comment-1738
We should implement/reuse that `attribution` logi... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19593 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19592"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.mysite.cards.dashboard.bloggingprompts.BloggingPromptCardBuilderTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/main/CompactBloggingPromptCardViewHolder.kt b/WordPress/src/main/java/org/wordpress/android/ui/main/CompactBloggingPromptCardViewHolder.kt
index bf5cedf0e23e..b6793405407a 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/main/CompactBloggingProm... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardBuilderTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardBuilderTest.kt
index a7c5381131f2..d109707fe366 100644
--- a/WordPress/src/tes... | {
"org.wordpress.android.ui.mysite.cards.dashboard.bloggingprompts.BloggingPromptCardBuilderTest.given blogging prompt, when card is built then return matching card": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.cards.dashboard.bloggingprompts.BloggingPromptCardBu... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19590 | wordpress-mobile | WordPress-Android | 19,590 | closed | [Bloganuary] Add bloganuary tags to Bloganuary prompt answers | Fixes #19588
If the prompt returned by the API has the `bloganuary_id`, and therefore the `BloggingPromptModel` from FluxC has the `bloganuaryId` field, then we should also add the `bloganuary` and `bloganuary-YYYY-DD` tags (this second one IS the content of the `bloganuaryId` field).
## To test
Since this reli... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "e5163c5d126e1205269f177657e5f590f103daf6"
} | [
{
"number": 19588,
"title": "[Bloganuary] Add Bloganuary tags to prompt answers",
"body": "Use `bloganuaryId` field from `BloggingPromptModel` to get one of the bloganuary tags for the post, the other tag should be `bloganuary` and should be added if the `bloganuaryId` field is present."
}
] | kotlin | [Bloganuary] Add Bloganuary tags to prompt answers
Use `bloganuaryId` field from `BloggingPromptModel` to get one of the bloganuary tags for the post, the other tag should be `bloganuary` and should be added if the `bloganuaryId` field is present.
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19590 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19588"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.bloggingprompts.editor.EditorBloggingPromptsViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/bloggingprompts/BloggingPromptsPostTagProvider.kt b/WordPress/src/main/java/org/wordpress/android/ui/bloggingprompts/BloggingPromptsPostTagProvider.kt
index 14319a5319ba..0600bbcff449 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/bloggingprom... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/editor/EditorBloggingPromptsViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/editor/EditorBloggingPromptsViewModelTest.kt
index f79de2779589..4c8c5ee0cfe8 100644
--- a/WordPress/src/test/java/org/wordpress/a... | {
"org.wordpress.android.ui.bloggingprompts.editor.EditorBloggingPromptsViewModelTest.should load blogging prompt mapped block": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.bloggingprompts.editor.EditorBloggingPromptsViewModelTest.should add bloganuary tags": {
"run... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19585 | wordpress-mobile | WordPress-Android | 19,585 | closed | 🤖 Prevent navigation outside the domain details webview enhancements | Fixes #19501
## Description
This PR enhances the implementation of https://github.com/wordpress-mobile/WordPress-Android/pull/19570 aligning with our internal discussion (ref p1699462442594229-slack-C05NS0YV7HS). With this:
* Navigation is only allowed in the `https://wordpress.com/domains/manage/all/some.domain/e... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "735ebd680cdba2fe34b6e739cc1b79dcc0dc6150"
} | [
{
"number": 19501,
"title": "🤖 Prevent navigation outside the domain details webview",
"body": "As documented in pc8HXX-1gR-p2:\nUsers should not be able to navigate to URLs outside of the domain details context. These URLs should be intercepted and opened in the device’s browser instead.\n\nrelated PR... | kotlin | 🤖 Prevent navigation outside the domain details webview
As documented in pc8HXX-1gR-p2:
Users should not be able to navigate to URLs outside of the domain details context. These URLs should be intercepted and opened in the device’s browser instead.
related PR: https://github.com/wordpress-mobile/WordPress-Android/pul... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19585 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19501"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.management.details.DomainManagementDetailsWebViewClientTest" --tests "org.wordpress.android.ui.domains.management.DomainManagementViewModelTest" --tests "org.wordpress.android.ui.domains.management.details.DomainManagementD... | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/domains/management/DomainManagementActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/domains/management/DomainManagementActivity.kt
index 6574c602cb0f..f439e6baf1db 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/domains/management... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/management/DomainManagementViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/management/DomainManagementViewModelTest.kt
index 310dc09d36f2..4650821f6a1f 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/domains/... | {
"org.wordpress.android.ui.domains.management.DomainManagementViewModelTest.GIVEN successful domains result and query is not blank WHEN search query changed THEN return populated loaded filtered UI state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19577 | wordpress-mobile | WordPress-Android | 19,577 | closed | [Jetpack Social] Remove feature flag | Fixes #19576
To test:
Taken from https://github.com/wordpress-mobile/WordPress-Android/pull/18897
1 - Open the app
2 - Go to Posts
3 - Open a Draft post / create a new post
4 - Open the Post Settings
5 - Verify the JP Social section is available
6 - Hit Publish
7 - Verify the JP Social item is available... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "44a38b0844874b5dfd1caa198ee678dd6264ff3e"
} | [
{
"number": 19576,
"title": "[Jetpack Social] Remove feature flag",
"body": "Remove Jetpack Social feature flag, since the feature was successfully released."
}
] | kotlin | [Jetpack Social] Remove feature flag
Remove Jetpack Social feature flag, since the feature was successfully released.
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19577 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19576"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.EditorJetpackSocialViewModelTest" | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index 64b5255f59ea..f5166ba8e345 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -138,7 +138,6 @@ android {
buildConfigField "boolean", "ENABLE_BLAZE_FEATURE", "false"
buildConfigField "boolean", "WP_INDIVIDUAL_PLUGIN_OVE... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditorJetpackSocialViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/EditorJetpackSocialViewModelTest.kt
index 1e05b7d4f486..a7c45b2b0238 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/EditorJetpackSocialVie... | {
"org.wordpress.android.ui.posts.EditorJetpackSocialViewModelTest.Should track SHARING_CONNECTION_TOGGLED when connection item is clicked": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.EditorJetpackSocialViewModelTest.Should track ADD_CONNECTION_DISMISSED when not... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19574 | wordpress-mobile | WordPress-Android | 19,574 | closed | Cancel stale request on domain search screen | Fixes #19563
The request is canceled when it takes longer than the updated query is received. It was reached by using the flatMapLatest operator, which is a part of the Experimental Coroutines API though.
To test:
- Enable `domain_management` feature flag
- Go to Me -> Domains -> (+)
- Try to type random chara... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "44a38b0844874b5dfd1caa198ee678dd6264ff3e"
} | [
{
"number": 19563,
"title": "🤖 Cancel stale requests on domain search screen",
"body": "When searching for a new domain (to purchase) within the domain management flow, the results of multiple requests are loaded sequentially after typing. Only the latest request should be used to update the pending / ... | kotlin | 🤖 Cancel stale requests on domain search screen
When searching for a new domain (to purchase) within the domain management flow, the results of multiple requests are loaded sequentially after typing. Only the latest request should be used to update the pending / loading screen.
Note that this is a separate concern fr... | null | https://github.com/wordpress-mobile/WordPress-Android/pull/19574 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19563"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/domains/management/newdomainsearch/NewDomainSearchViewModel.kt b/WordPress/src/main/java/org/wordpress/android/ui/domains/management/newdomainsearch/NewDomainSearchViewModel.kt
index 9c79f4b6a217..f1a3a1af30d2 100644
--- a/WordPress/src/main/java/org/wordpre... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/management/newdomainsearch/NewDomainSearchViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/management/newdomainsearch/NewDomainSearchViewModelTest.kt
index 6298a2ee56d5..c27fdfb1fe44 100644
--- a/WordPress/src/test/java/org... | {
"org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchViewModelTest.WHEN a domain is tapped THEN track DOMAIN_MANAGEMENT_SEARCH_DOMAIN_TAPPED event": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchVi... | {
"org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchViewModelTest.GIVEN successful search for domain result WHEN onSearchQueryChanged THEN emit populated domains UI state": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.newdomai... | {
"org.wordpress.android.ui.domains.management.newdomainsearch.NewDomainSearchViewModelTest.WHEN transfer domain button pressed THEN track DOMAIN_MANAGEMENT_TRANSFER_DOMAIN_TAPPED event": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.newdomainsearch.New... | {} |
wordpress-mobile__WordPress-Android-19547 | wordpress-mobile | WordPress-Android | 19,547 | closed | Update search logic to include blog name and status | Fixes #19484
This PR includes additional "blog name" and "status" properties to filter my domains list by. In addition, I moved the filter logic from the UI layer to the ViewModel to make it more efficient. The previous implementation caused unnecessary invoking of filtering while scrolling the list. Composables sho... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "fb5384dcdcd3b5706f9265ab7bc2f0ea9dc4348a"
} | [
{
"number": 19484,
"title": "🤖 Update search logic to include blog name and status",
"body": "This task is to update the \"My domains\" search logic to match on `blogName` and `status`."
}
] | kotlin | 🤖 Update search logic to include blog name and status
This task is to update the "My domains" search logic to match on `blogName` and `status`.
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19547 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19484"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.management.DomainManagementViewModelTest" --tests "org.wordpress.android.ui.domains.management.util.DomainLocalSearchEngineTest" --tests "org.wordpress.android.ui.domains.management.PopulatedListTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/domains/management/DomainManagementActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/domains/management/DomainManagementActivity.kt
index 8d39603ac8cf..5fec8c1a1a04 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/domains/management... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/management/DomainManagementViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/management/DomainManagementViewModelTest.kt
index 716480b54830..f7014f808bbe 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/domains/... | {
"org.wordpress.android.ui.domains.management.DomainManagementViewModelTest.WHEN a navigation back button is tapped THEN send NavigateBackTapped action event": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.DomainManagementViewModelTest.WHEN ViewModel i... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19509 | wordpress-mobile | WordPress-Android | 19,509 | closed | Handle navigation back button on the All Domain screen | Fixes #19503
This PR handles navigation back button on the "All Domains" screen.
To test:
- Make sure you have enabled `domain_management` feature flag
- Go to "Me" tab -> Domains
- [ ] Make sure that the navigation back button navigates back to the "Me" tab
https://github.com/wordpress-mobile/WordPress-And... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "dfbd8bca07eb8c5657d3e3f5a43261bbd11b0dad"
} | [
{
"number": 19503,
"title": "🤖 Add back button action in the domains list screen",
"body": "Adding this as a reminder to add the back button action in the domains list screen"
}
] | kotlin | 🤖 Add back button action in the domains list screen
Adding this as a reminder to add the back button action in the domains list screen
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19509 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19503"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.domains.management.DomainManagementViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/domains/management/DomainManagementActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/domains/management/DomainManagementActivity.kt
index 0fec612b0c80..8d39603ac8cf 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/domains/management... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/domains/management/DomainManagementViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/domains/management/DomainManagementViewModelTest.kt
index b8eef4fd4fab..716480b54830 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/domains/... | {
"org.wordpress.android.ui.domains.management.DomainManagementViewModelTest.WHEN a domain is tapped THEN send DomainTapped action event": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.domains.management.DomainManagementViewModelTest.WHEN a domain is tapped THEN track DOM... | {} | {} | {} |
wordpress-mobile__WordPress-Android-19424 | wordpress-mobile | WordPress-Android | 19,424 | closed | UI Modernization Post: Remove post list compact layout | Fixes #19340
This PR is the first in a series which will implement a new look/feel for the Post lists. This focus of this PR was to remove the "compact" layout and any associated logic. No visual changes in this PR.
**Changes Include**
-- Remove compact layout and drawable resources
- post_list_item_com... | {
"label": "wordpress-mobile:feature/ui-modernization-posts-and-pages",
"ref": "feature/ui-modernization-posts-and-pages",
"sha": "35191692826400b4f84db84daecb8723fcd3a971"
} | [
{
"number": 19340,
"title": "UI Modernization Posts: Remove compact layout filter",
"body": "\r\n```[tasklist]\n### Tasks\n- [x] Remove layouts files\n- [x] Remove string resources\n- [x] Remove from toolbar menu\n- [x] Remove logic associated with changing the layout filter\n```\r\n"
}
] | kotlin | UI Modernization Posts: Remove compact layout filter
```[tasklist]
### Tasks
- [x] Remove layouts files
- [x] Remove string resources
- [x] Remove from toolbar menu
- [x] Remove logic associated with changing the layout filter
```
| null | https://github.com/wordpress-mobile/WordPress-Android/pull/19424 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/19340"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.ui.posts.PostListMainViewModelTest" | diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListFragment.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListFragment.kt
index 2bed7dde2923..a467fb5ea7d3 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostListFragment.kt
+++ b/WordPress/src/main/java/org/... | diff --git a/WordPress/src/test/java/org/wordpress/android/ui/posts/PostListMainViewModelTest.kt b/WordPress/src/test/java/org/wordpress/android/ui/posts/PostListMainViewModelTest.kt
index 1aac211ab4fb..57bbb125e1b5 100644
--- a/WordPress/src/test/java/org/wordpress/android/ui/posts/PostListMainViewModelTest.kt
+++ b/W... | {} | {
"org.wordpress.android.ui.posts.PostListMainViewModelTest.when started, it uploads all local drafts": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"org.wordpress.android.ui.posts.PostListMainViewModelTest.expanding search after configuration change preserves search query": {
"run": "PASS",
... | {} | {} |
wordpress-mobile__WordPress-Android-19135 | wordpress-mobile | WordPress-Android | 19,135 | closed | Domain dashboard card: Remove feature flag | Fixes #18725
Removing domain dashboard card, and clean up all related as it is superseded by Plans project.
To test:
- Launch JP app
- `Go` to Me -> Debug settings
- `Verify` no dashboard_card_domain feature flag is present
- `Go` to Home
- `Verify` **Home**, **Menu** options on dashboard all work as befo... | {
"label": "wordpress-mobile:trunk",
"ref": "trunk",
"sha": "eed6684076be3f8738caabd7b67eb8b935ac1aea"
} | [
{
"number": 18725,
"title": "Domain Dashboard Card: Remove related code",
"body": "With the inclusion of Plans related card, Domain Dashboard Card is no longer needed:\n\n- [ ] Remove dashboard card UI code\n- [ ] Remove the feature flag\n- [ ] Remove presentation criteria"
}
] | kotlin | Domain Dashboard Card: Remove related code
With the inclusion of Plans related card, Domain Dashboard Card is no longer needed:
- [ ] Remove dashboard card UI code
- [ ] Remove the feature flag
- [ ] Remove presentation criteria
| Hey @staskus
reminder: please make sure to remove the remote flags/local flags related to this as well. | https://github.com/wordpress-mobile/WordPress-Android/pull/19135 | [
"https://github.com/wordpress-mobile/WordPress-Android/issues/18725"
] | ./gradlew :WordPress:testWordpressVanillaDebugUnitTest --tests "org.wordpress.android.e2e.DashboardTests" --tests "org.wordpress.android.ui.mysite.cards.dashboard.CardsBuilderTest" --tests "org.wordpress.android.ui.mysite.cards.dashboard.domain.DashboardDomainCardBuilderTest" --tests "org.wordpress.android.ui.mysite.My... | diff --git a/WordPress/build.gradle b/WordPress/build.gradle
index c846fb90b3df..ed92e54a0051 100644
--- a/WordPress/build.gradle
+++ b/WordPress/build.gradle
@@ -146,7 +146,6 @@ android {
buildConfigField "boolean", "JETPACK_INSTALL_FULL_PLUGIN", "false"
buildConfigField "boolean", "ENABLE_BLAZE_FEAT... | diff --git a/WordPress/src/androidTest/java/org/wordpress/android/e2e/pages/DomainsScreen.kt b/WordPress/src/androidTest/java/org/wordpress/android/e2e/pages/DomainsScreen.kt
deleted file mode 100644
index a218f46451c9..000000000000
--- a/WordPress/src/androidTest/java/org/wordpress/android/e2e/pages/DomainsScreen.kt
+... | {
"org.wordpress.android.ui.mysite.cards.CardsBuilderTest.given quick start in progress, when site is selected, then QS card built": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.wordpress.android.ui.mysite.MySiteViewModelTest.given remove undo snackbar, when undo is clicked, then it updates ... | {} | {} | {} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.